Repository navigation
Conversation
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — Update dialogs now support outside-click dismissal while retaining explicit confirmation before updates run. The change is limited to dialog interaction and presentation, without changing update execution or saved settings. You can add or adjust custom eligibility rules. Learn more. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
d33a641 to
1df6054
Compare
|
Note Written by Verified in a real dev environmentverified head created a project pointing at the real checkout and ran Codex
before, after the outside click on main: after, after the outside click on the pr: Not verified
|



Problem
The update confirmation ("Update N machines?" from the sidebar, and "Switch to Stable/Nightly" from Settings) stays open when you click outside it. Every other popup in the app closes on an outside click.
To reproduce: with a provider or app update available, click the sidebar update button, then click the dimmed backdrop.
Change
Both dialogs used Base UI's
AlertDialog, which never dismisses on outside press by design. They now use the regularDialogwrapper with no close button, so they look the same and close on an outside click, Escape, or Cancel.role="alertdialog", so screen readers still announce them as confirmations, and the shortcut guard from fix(web): app shortcuts wait while a confirmation dialog is open #27157 still keeps app shortcuts from firing behind them.onOpenChangeguard.wrap-anywhere, whichAlertDialogDescriptionused to provide, so a long registry error can't widen the popup.smbreakpoint the header is left-aligned instead of centered, matching the left-aligned machine table.Scope
A small fix for an obvious bug: one popup behaves differently from the rest of the app. No issue filed.
Verification
SidebarUpdatePill.browser.test.tsx: the pointer-cancel case is nowit.eachover Cancel and an outside press, and asserts thealertdialogis open before closing it. The outside-press row fails on main (dialog still open) and passes here. File passes 6/6.vp run check:changedpasses.role="alertdialog".DialogPopuppath the test covers.Council review
Rounds: 2
Created with Claude Opus 5.5 in Claude Code (via T3 Code). Council reviews by Claude Opus 5.5 and Muse Wonder 1.0.