You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(server): issue links on a custom GitHub Enterprise hostname resolve - #38269
Nothing needed changing this round. PR #38269 at de49a97 passed all 8 required checks. Macroscope approved it with no comments on any lines, CodeRabbit had not posted anything, and the thread-transfer report says the PR stays within every limit, so there were no findings to fix. The fix itself is unchanged. GitHub's parseIssueUrl now takes the known flag that parseCommitUrl already has. When the normal parse fails, IssueService.resolveUrl and the client's resolveIssueLinkTarget parse the URL again as the provider of a project whose issue binding is on that host. GitHubSourceControlProvider also gains refineRepositoryIdentity, which works like GitLab's: a gh login on an unknown host turns the project into a GitHub project, so it gets an issue binding instead of 'tracker-unsupported'.
Commit bfd37b2 (origin/main). Created a git repo with remote https://code.acme.test/acme/web.git, started T3CODE_DEV_SEED=0 vp run dev in a fresh worktree, added the repo with t3 project add, enabled an OpenCode provider instance in the worktree's dev settings, and ran t3 thread start --provider opencode --model opencode/deepseek-v4.1-flash-free --wait asking the agent to read https://code.acme.test/acme/web/issues/7 with T3's issue tool. The agent's tool call returned: Issue operation resolveUrl failed: This is not a recognised issue URL. Control: the same steps with a project on https://github.acme.test/acme/web.git and the URL https://github.acme.test/acme/web/issues/7 got past URL resolution to the project and only failed on credentials (This tracker has no working credentials., expected with no sign-in). A probe of the server's source-control registry also showed that remote recognition returns provider unknown for code.acme.test and parseIssueUrl returns null for it, while github.acme.test is recognised as GitHub. Failing tests are on factory/repro-38251: an assertion in apps/server/src/issue/IssueService.test.ts (resolveUrl for a GitHub project on code.acme.test fails with 'This is not a recognised issue URL.') and one in packages/client-runtime/src/issueLinks.test.ts (resolveIssueLinkTarget returns undefined).
Evidence
Fresh per-commit databases; Chromium 1280×800 and native iOS 402×874, light theme. Create a project with origin https://code.acme.test/acme/web.git, run an agent turn calling the actual T3 read_issue MCP tool for https://code.acme.test/acme/web/issues/7, then tap the identical issue link. A strict synthetic HTTPS Enterprise fixture checks the hostname, credential, repository and issue number. Base rejects the URL; head retrieves the title, body, Open state and comment.
Live GitHub Enterprise Server and real Enterprise credentials were not exercised; successful retrieval used the strict synthetic HTTPS API fixture.
Android and the Electron shell were not captured; mobile coverage used the native iOS client.
Tests
No new runs this round. I checked the PR's checks and reviews over the GitHub REST API: 8/8 required checks passed on de49a97, Macroscope APPROVED, no comments on any lines. Earlier runs on this head: vp run check:changed (format, lint, knip, graphql, typecheck, 5 test files) passed; the issueLinks, IssueService, GitHubSourceControlProvider and sourceControlDefinitions tests passed.
Not in this change
repositoryUrlFromPage and changeRequestUrlFromReferenceAutolink in the GitHub definition still require a GitHub-looking hostname; links to repository pages and #N reference autolinks on a custom-hostname Enterprise Server are not upgraded.
Projects whose shell repositoryIdentity was cached as provider 'unknown' before this change pick up 'github' only when the identity cache refreshes (15-minute positive TTL).
Who did the work
Written by Claude Opus 5.5, in Claude Code
Reviewed by GPT-6.1 Sol, in Codex, and by Claude Opus 5.5, each on its own
Proof captured by GPT-6.1 Sol and checked by Claude Opus 5.5
)
Fails on main: GitHub's parseIssueUrl only accepts hostnames with a
github label or a .ghe.com suffix, so a project on code.acme.test
cannot resolve its own issue URLs in the agent tool or the issue panel.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitHub's issue URL parser only believed hostnames with a "github" label or
a .ghe.com suffix, so a GitHub Enterprise Server on any other hostname
could not resolve its own issue URLs in the agent's issue tool or the
issue panel. Such a project was also recognised as provider "unknown",
which gives it no issue binding at all.
The issue parser now takes the same `known` flag as the commit parser:
when a project's own host vouches for the URL, the server and client
retry the parse as that project's provider. GitHub also refines an
unknown-host repository identity through the gh login, as GitLab does
with glab, so the project gets a GitHub issue binding.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Macroscope's review found this PR approvable — Custom GitHub Enterprise issue links now resolve using a matching project's known provider. Existing host matching and read-only cross-repository boundaries limit the change's exposure.
You can add or adjust custom eligibility rules. Learn more.
Findings on this PR, from the #38251 work I had started before you took it over. Nothing here is pushed; the diff is local on issue-watch/38251.
Reproduced (not on a device): on base 38f7761148f, the repro in the issue body (the code.acme.test port case in packages/client-runtime/src/issueLinks.test.ts) fails with AssertionError: expected undefined to be 'ported'. The server cases in sourceControlDefinitions.test.ts and IssueService.test.ts fail with "This is not a recognised issue URL." I took these from the implementer's run on Linux; I did not rerun base myself.
Tested:fleet-job check --worktree on the working tree at 38f7761148f: format, lint, knip, graphql, typecheck (20 packages) and 5 test files (44 tests) passed.
Not tested: no device, the web client issue panel, or a real GitHub Enterprise host.
Review (read by reading the code, not executed):
R1 (should): tracker is chosen before authority, so a bare-hostname GitHub binding can outrank an exact-port binding. With GitHub on gitea.test ordered before Forgejo on gitea.test:8443, https://gitea.test:8443/acme/web/issues/7 resolves to the bare GitHub project. Same in issueLinks.ts and IssueService.ts.
R2 (should): client and server disagree when the first binding's tracker has no issue parser (e.g. Bitbucket before GitHub on code.acme.test). The client returns null; the server skips the unsupported tracker and resolves through GitHub.
R3 (nit):resolveUrl lists projects before parsing, so an ordinary URL with a project-list failure now returns a listProjects error instead of "not a recognised issue URL".
Issue URL resolution now tries the configured project’s provider for custom hosts when default parsing does not recognize a URL. Repository identity refinement also resolves provider context for remotes whose host is not recognized by hostname heuristics.
The parser registry accepts an optional provider kind and passes a known-host flag to the provider parser. The GitHub parser accepts issue paths when the host is known or recognized as GitHub.
The client and server try parsing with a configured project’s provider when default parsing does not recognize the URL. Tests cover custom-host issue URLs.
The GitHub provider resolves provider context for eligible repository identities and marks the provider as GitHub when the resolved context identifies GitHub. Tests cover GitHub and unknown results.
sequenceDiagram
participant Client as resolveIssueLinkTarget
participant Registry as SourceControlDefinitionRegistry
participant ProjectBindings
participant GitHub as GitHub definition
Client->>Registry: Parse URL with default provider selection
Registry-->>Client: Return no match
Client->>ProjectBindings: Find bindings matching URL hostname or authority
ProjectBindings-->>Client: Return matching project provider
Client->>Registry: Parse URL with project provider kind
Registry->>GitHub: Parse URL with known host flag
GitHub-->>Client: Return issue link
Loading
sequenceDiagram
participant IssueService as IssueService.resolveUrl
participant Registry as SourceControlDefinitionRegistry
participant Tracker as Standalone tracker parser
participant Projects as Supported projects
IssueService->>Registry: Parse URL with default provider selection
Registry-->>IssueService: Return no match
IssueService->>Tracker: Try standalone tracker parsing
Tracker-->>IssueService: Return no match
IssueService->>Projects: Find projects on URL hostname
Projects-->>IssueService: Return project tracker kinds
IssueService->>Registry: Parse URL using each project tracker kind
Registry-->>IssueService: Return matching issue link
Loading
Possibly related issues
pingdotgg/t3code#38009 concerns matching issue URLs to project bindings by hostname and authority, which is also part of this change.
Possibly related PRs
pingdotgg/t3code#38252 changes issue URL resolution for custom GitHub Enterprise hosts through project-bound provider parsing.
Issue links on GitHub Enterprise hosts with custom hostnames such as code.acme.test should now resolve through the project bound to that host. No concrete merge-blocking defect remains; the only open item is a minor tracing-convention nit.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: issue links on a custom GitHub Enterprise hostname (for example code.acme.test) now resolve. The raw summary shows the changeset adds a known flag to issue URL parsing…
Linked Issues check
[#38251] Requirement: an issue URL on a custom GitHub Enterprise hostname (for example code.acme.test) resolves through the configured project, in the agent issue tool and in the internal issue panel.…
Out of Scope Changes check
Each change maps to the issue path. Changes in apps/server/src/issue/IssueService.ts and packages/client-runtime/src/issueLinks.ts add the project-host fallback for URL resolution. Changes in packages…
Description check
The description follows the template's main sections (Problem, Change, Scope, Verification) and states the root cause, the fix, and a reproduction on main. It links issue #38251 and gives extensive ve…
Full details: Title check
Explanation
The title names the main change: issue links on a custom GitHub Enterprise hostname (for example code.acme.test) now resolve. The raw summary shows the changeset adds a known flag to issue URL parsing, a project-host fallback in IssueService and resolveIssueLinkTarget, and GitHub identity refinement for unknown hosts, all aimed at that outcome. The title follows the conventional commit form and is specific.
Full details: Linked Issues check
Explanation
[#38251] Requirement: an issue URL on a custom GitHub Enterprise hostname (for example code.acme.test) resolves through the configured project, in the agent issue tool and in the internal issue panel. The change set covers both paths. GitHub's definition parseIssueUrl accepts /owner/repo/issues/N when the new known flag is true. The registry parseIssueUrl accepts an optional provider kind. IssueService.resolveUrl on the server and resolveIssueLinkTarget on the client both retry parsing with the provider of a project whose issue binding matches the link host or authority, after the standalone-tracker check. GitHubSourceControlProvider.refineRepositoryIdentity turns an unknown-host identity into provider 'github' when the cached gh credential context confirms the host, so the project binding exists. Tests were added in IssueService.test.ts, issueLinks.test.ts, and GitHubSourceControlProvider.test.ts. The lookalike-host guard is kept: a host with no matching project stays unrecognised. Basis: PR summary and description; source was not re-read in this assessment. The author did not run an end-to-end check in a running app. That is a verification gap, not a coding requirement.
Full details: Out of Scope Changes check
Explanation
Each change maps to the issue path. Changes in apps/server/src/issue/IssueService.ts and packages/client-runtime/src/issueLinks.ts add the project-host fallback for URL resolution. Changes in packages/source-control-core/src/shared/definition.ts add the known flag and optional provider kind that the fallback needs. Changes in packages/source-control-github/src/shared/definition.ts apply the known flag to GitHub parsing. Changes in packages/source-control-github/src/server/GitHubSourceControlProvider.ts add the identity refinement that makes the project binding usable. The matching test files cover these changes. The PR description states the excluded items: repository-page URLs and #N autolinks are not changed, and cached 'unknown' identities refresh on the 15-minute TTL. These exclusions are stated limits, not unrelated changes. No change was found that is unconnected to issue #38251. Basis: PR summary and description; source was not re-read in this assessment.
Full details: Description check
Explanation
The description follows the template's main sections (Problem, Change, Scope, Verification) and states the root cause, the fix, and a reproduction on main. It links issue #38251 and gives extensive verification evidence. However, it opens with a status and review report that does not belong in the description, and the Problem section lacks a clear expected-behavior statement. The Scope section does not explain the reason for a fix without a dedicated bug-link preamble, though it does link the issue. The Verification section includes the required tests and a note about what was not checked. The 'Who did the work' section names the models, which the template asks for. The description is mostly complete, so it passes.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.
Use the required Effect function builder for this fallback.
Define parseOnProjectHost with Effect.fn("IssueService.parseOnProjectHost"). This gives the project-enumeration fallback a distinct tracing boundary while preserving its null and error results.
As per coding guidelines, “Reusable Effect functions use Effect.fn("Service.operation") with a stable span name.”
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:L100-499 changed lines (additions + deletions).vouch:trustedAuthor is trusted by repo permissions or the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing needed changing this round. PR #38269 at de49a97 passed all 8 required checks. Macroscope approved it with no comments on any lines, CodeRabbit had not posted anything, and the thread-transfer report says the PR stays within every limit, so there were no findings to fix. The fix itself is unchanged. GitHub's parseIssueUrl now takes the
knownflag that parseCommitUrl already has. When the normal parse fails, IssueService.resolveUrl and the client's resolveIssueLinkTarget parse the URL again as the provider of a project whose issue binding is on that host. GitHubSourceControlProvider also gains refineRepositoryIdentity, which works like GitLab's: a gh login on an unknown host turns the project into a GitHub project, so it gets an issue binding instead of 'tracker-unsupported'.Fixes #38251
Reproduction on main
Commit bfd37b2 (origin/main). Created a git repo with remote https://code.acme.test/acme/web.git, started
T3CODE_DEV_SEED=0 vp run devin a fresh worktree, added the repo witht3 project add, enabled an OpenCode provider instance in the worktree's dev settings, and rant3 thread start --provider opencode --model opencode/deepseek-v4.1-flash-free --waitasking the agent to read https://code.acme.test/acme/web/issues/7 with T3's issue tool. The agent's tool call returned:Issue operation resolveUrl failed: This is not a recognised issue URL.Control: the same steps with a project on https://github.acme.test/acme/web.git and the URL https://github.acme.test/acme/web/issues/7 got past URL resolution to the project and only failed on credentials (This tracker has no working credentials., expected with no sign-in). A probe of the server's source-control registry also showed that remote recognition returns providerunknownfor code.acme.test and parseIssueUrl returns null for it, while github.acme.test is recognised as GitHub. Failing tests are on factory/repro-38251: an assertion in apps/server/src/issue/IssueService.test.ts (resolveUrl for a GitHub project on code.acme.test fails with 'This is not a recognised issue URL.') and one in packages/client-runtime/src/issueLinks.test.ts (resolveIssueLinkTarget returns undefined).Evidence
Fresh per-commit databases; Chromium 1280×800 and native iOS 402×874, light theme. Create a project with origin https://code.acme.test/acme/web.git, run an agent turn calling the actual T3 read_issue MCP tool for https://code.acme.test/acme/web/issues/7, then tap the identical issue link. A strict synthetic HTTPS Enterprise fixture checks the hostname, credential, repository and issue number. Base rejects the URL; head retrieves the title, body, Open state and comment.
Both scenarios: failsOnBase=true, passesOnHead=true, exit 0. Mobile recordings omit installation and pairing.
Web scenario, iOS scenario, agent driver, HTTPS fixture, DNS setup, reproduction command, actual MCP transcript, request routing audit.
Complete runner-generated evidence, including stability captures and verdicts.
Not shown:
Tests
No new runs this round. I checked the PR's checks and reviews over the GitHub REST API: 8/8 required checks passed on de49a97, Macroscope APPROVED, no comments on any lines. Earlier runs on this head: vp run check:changed (format, lint, knip, graphql, typecheck, 5 test files) passed; the issueLinks, IssueService, GitHubSourceControlProvider and sourceControlDefinitions tests passed.
Not in this change
Who did the work
Run by the t3code factory in T3 Code.