Skip to content

fix(server): label Copilot rg calls as file searches - #38512

Merged
juliusmarminge merged 3 commits into
pingdotgg:mainfrom
amv146:fix/copilot-rg-tool-labels
Nov 18, 2026
Merged

juliusmarminge merged 3 commits into
pingdotgg:mainfrom
amv146:fix/copilot-rg-tool-labels

Conversation

@amv146

@amv146 amv146 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Problem

Copilot's built-in rg calls can appear as generic tools instead of file searches.

Change

Add rg to the existing Copilot search-tool allowlist.

Scope

Follow-up to #38349; related to #38346.

Verification

  • From apps/server: vp test run src\orchestration-v2\Adapters\AcpRegistryAdapterV2.test.ts -t 'keeps Copilot' - passed both cases.
  • vp run --filter @t3tools/provider-acp-registry typecheck - passed.
  • vp run check:changed --concurrency 1 - blocked by missing dependencies.
  • Real-client replay confirmed the generic tool entry becomes a file-search entry.

Model: GPT-6.1 Sol. Harness: GitHub Copilot via ACP.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added vouch:unvouched Author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Nov 18, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 2b8bbd7

Macroscope's review found this PR approvable — Copilot rg calls now use the existing file-search classification and presentation. This narrow labeling correction does not change tool execution, permissions or product defaults.

You can add or adjust custom eligibility rules. Learn more.

@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Copilot search tool list now includes rg. The adapter test checks that both glob and rg project to file_search.

Changes: Copilot search identity

Layer / File(s) Summary
Recognize rg as a search tool
packages/provider-acp-registry/src/server/copilotAcp.ts, apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts
COPILOT_SEARCH_TOOLS now includes rg. The adapter test checks the projected file_search identity for both glob and rg. It expects native search kind read for glob and other for rg.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Possibly related PRs

  • pingdotgg/t3code#38349: Adds the Copilot search-tool identity handling for built-in glob and grep calls, which this change extends.

Suggested labels: bugfix

Suggested reviewers: juliusmarminge, maria-rcks

Merge Risk: Minimal · up to e4d35

Copilot's built-in rg calls will now appear as file searches rather than generic tool entries. The change is small and covered by a test, so merge risk is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "fix(server): label Copilot rg calls as file searches" matches the main change. The PR adds rg to the Copilot search-tool allowlist (COPILOT_SEARCH_TOOLS), so rg calls are classified as …
Description check Passed The description follows the template and fills in the key sections. Problem states that Copilot's built-in rg calls can appear as generic tools. Change states that rg is added to the existing Copi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix(server): label Copilot rg calls as file searches" matches the main change. The PR adds rg to the Copilot search-tool allowlist (COPILOT_SEARCH_TOOLS), so rg calls are classified as file searches. The title is specific, follows conventional commit form, and contains no vague terms.

Full details: Description check

Explanation

The description follows the template and fills in the key sections. Problem states that Copilot's built-in rg calls can appear as generic tools. Change states that rg is added to the existing Copilot search-tool allowlist. Scope links related issues (#38349 as a follow-up, #38346 as related). Verification lists focused test and typecheck commands with observed results, notes the check:changed run was blocked, and reports a real-client replay. The template's required Scope element asks for a linked bug issue; this PR links related issues but does not clearly state the bug issue itself, and the template's model/harness line is present. These gaps are minor, so the description is mostly complete.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 2b8bbd7 and e4d3539.

Files selected for processing: 1

  • apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

@juliusmarminge juliusmarminge added the takeover:in-progress A takeover lead is working on this PR label Nov 18, 2026
@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Created identical two-file projects on fresh databases and ran the reported prompt through real Copilot CLI 1.0.114 with GPT-6 Luna. Native session events confirmed rg with {pattern: "needleValue", output_mode: "files_with_matches"} on both commits. Expanded the prompt and activity in the web client. Environment for both captures: 1280×800 browser viewport, light theme, device scale 2.

Before After
316c3256a3 e4d3539ec8
Before: Copilot rg rendered as Tool with a wrench After: Copilot rg rendered as Searched needleValue with a search icon

Parameterized reproduction driver · Native-event and projected-item observations

Both captures were opened and inspected before upload; each matched a second screenshot taken more than 500 ms later byte for byte.

Not shown:

  • Registry installation and discovery UI were not exercised: both apps used the unmodified Copilot CLI 1.0.114 executable configured as a local command through the ACP Registry adapter.
  • Raw ACP kind other was not captured; native rg identity, the resulting projected item, and the visible before/after classification were verified.

@juliusmarminge juliusmarminge added takeover:ready Takeover done; auto-lands when gates pass and removed takeover:in-progress A takeover lead is working on this PR labels Nov 18, 2026
@juliusmarminge
juliusmarminge merged commit d0a754d into pingdotgg:main Nov 18, 2026
56 checks passed
@juliusmarminge juliusmarminge removed the takeover:ready Takeover done; auto-lands when gates pass label Nov 18, 2026
AIdoesmyjob pushed a commit to AIdoesmyjob/t3code that referenced this pull request Nov 18, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
(cherry picked from commit d0a754d)
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 18, 2026
**v0.1.11-nightly.20261118.4890** · 35 changes from 19 contributors

- **Thread-aware terminals.** Run thread-aware commands from integrated terminals without specifying the thread.
- **Antigravity sign-in.** Sign in to Antigravity on servers without a graphical display.
- **Antigravity turns.** Antigravity threads can complete turns without failing during initialization.

### Plus 31 more bug fixes.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(server): label Copilot rg calls as file searches by @amv146 in pingdotgg/t3code#38512
* fix(web): keep Ready pending label until its request finishes by @Yash-Singh1 in pingdotgg/t3code#38517
* fix(azure-devops): issue lists reuse each project's states and survive a refresh while loading by @juliusmarminge in pingdotgg/t3code#38508
* fix(acp): Devin terminals no longer inherit the launching thread's T3 MCP credentials by @ianrowe12 in pingdotgg/t3code#26652
* fix(web): a ~\ home path opens as a read-only home file, not as a project file by @SouthCarpet in pingdotgg/t3code#38510
* fix(web): thread jump hints re-check when a modifier changes while the hold is already met by @juliusmarminge in pingdotgg/t3code#38545
* fix(server): Changes base follows the remote a plain recorded base branch tracks by @juliusmarminge in pingdotgg/t3code#38543
* fix(web): the issue viewer shows why a refresh failed by @StiensWout in pingdotgg/t3code#38537
* fix(shared): Latin letters such as ł, ø, þ and ı no longer split words in generated folder and branch names by @SouthCarpet in pingdotgg/t3code#38540
* fix(server): steering a running turn carries MCP app model context by @juliusmarminge in pingdotgg/t3code#38554
* fix(web): thread details rows no longer show stray scrollbars on touch screens by @tris203 in pingdotgg/t3code#38546
* fix(web): very wide or tall lone images in user messages show the whole image by @juliusmarminge in pingdotgg/t3code#38558
* fix(mobile): a retried document upload keeps its tile and shows progress by @StiensWout in pingdotgg/t3code#38553
* fix(client-runtime): closed issue searches no longer build up in memory by @StiensWout in pingdotgg/t3code#38493
* fix(acp-registry): each Mistral Vibe model shows its own thinking levels by @amtiYo in pingdotgg/t3code#38556
* fix(server): Cursor history on large accounts loads in pieces and keeps what was read by @juliusmarminge in pingdotgg/t3code#38567
* fix(web): idle numbered terminals show their name in the app language by @StiensWout in pingdotgg/t3code#38565
* fix(server): the first message on an imported conversation sends its history once by @juliusmarminge in pingdotgg/t3code#38575
* fix(pi): worktree handoff no longer leaves Pi threads Waiting by @juliusmarminge in pingdotgg/t3code#38582
* fix(mobile): use the shared rounded frame for issue details by @PixPMusic in pingdotgg/t3code#38491
* fix(server): an Antigravity update refreshes every instance's model list by @sittingmongoose in pingdotgg/t3code#36035
* test(release): release smoke refreshes the committed lockfile instead of resolving every package fresh by @juliusmarminge in pingdotgg/t3code#38592
* fix(server): Antigravity turns no longer fail on a roots notification to the T3 MCP server by @Bert0ns in pingdotgg/t3code#36439
* fix(server): Antigravity 1.5 asks for sign-in when it cannot open a browser by @sittingmongoose in pingdotgg/t3code#36037
* fix(server): integrated terminals get T3CODE_THREAD_ID like agent sessions by @frankhommers in pingdotgg/t3code#35006
* fix(antigravity): thread sessions spawn with their T3 thread and MCP environment by @marsidev in pingdotgg/t3code#36495
* fix(server): server preview tabs opened at startup no longer stay loading by @Kenmege in pingdotgg/t3code#37406
* fix(server): a Claude command moved to the background keeps its command in Background work by @josephv123 in pingdotgg/t3code#37787
* fix(server): restart note says how to resume a cut Claude subagent by @0xpolarzero in pingdotgg/t3code#37266
* fix(server): preserve explicit document breaks in RTF attachment text by @Lucenx9 in pingdotgg/t3code#38598
* fix(server): preserve raw notebook cell labels in attachment text by @Lucenx9 in pingdotgg/t3code#38612
* fix(server): Hermes Agent's reply after a background process finishes reaches the thread by @juliusmarminge in pingdotgg/t3code#38615
* fix(server): Claude text generation sends attached images by @juliusmarminge in pingdotgg/t3code#38619
* fix(server): RTF tracked deletions are left out of the extracted text by @Marve10s in pingdotgg/t3code#38605
* fix(server): a finished run no longer keeps an unused file index alive by @antoniooo12 in pingdotgg/t3code#38585

## New Contributors
* @amtiYo made their first contribution in pingdotgg/t3code#38556
* @sittingmongoose made their first contribution in pingdotgg/t3code#36035
* @Bert0ns made their first contribution in pingdotgg/t3code#36439
* @marsidev made their first contribution in pingdotgg/t3code#36495
* @Kenmege made their first contribution in pingdotgg/t3code#37406
* @0xpolarzero made their first contribution in pingdotgg/t3code#37266
* @antoniooo12 made their first contribution in pingdotgg/t3code#38585

**Full Changelog**: pingdotgg/t3code@v0.1.11-nightly.20261118.4877...v0.1.11-nightly.20261118.4890

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.11-nightly.20261118.4890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants