Repository navigation
perf(server): status subscribe and branch switch no longer read local Git status twice #38949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amv146
wants to merge
6
commits into
pingdotgg:main
Choose a base branch
from
amv146:perf/skip-duplicate-local-status-read
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+230
−24
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
96ec3c8
perf(server): status subscribe and branch switch no longer read local…
amv146 e1fced8
fix(server): certify the first subscription read from git, not the st…
amv146 2900175
Merge remote-tracking branch 'origin/main' into perf/skip-duplicate-l…
juliusmarminge 8572329
refactor(server): take the ref snapshot before the local read it vouc…
juliusmarminge b210b4e
Merge the author's cache invalidation into the sequential ref snapshot
juliusmarminge add4601
perf(server): a checkout's HEAD watch shares the checkout's local read
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not reuse an earlier local read after base refs move.
If a local refresh completes while the HEAD watch's remote read is pending, its shared result can satisfy
localRequestedAt. If an external fetch then moves the base ref,readRemoteStatusdoes not detect that change when the branch name stays the same. The null-baseline path reuses the earlier local result and leaves Changes totals stale until another refresh.Previously, reconciliation requested its local read after the remote read. Require ref certification before reusing the earlier result. Otherwise, issue a new local request after the remote read. Keep reuse when refs are certified unchanged.