Skip to content

fix(web): remove repeated model name from reasoning header - #39058

Closed
saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:fix/model-picker-reasoning-header
Closed

saphid wants to merge 1 commit into
pingdotgg:mainfrom
saphid:fix/model-picker-reasoning-header

Conversation

@saphid

@saphid saphid commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Problem

The model picker repeats the selected model name in the top-right corner beside “Reasoning”, adding clutter when the selected row already identifies it.

Change

Remove the repeated header label and the React context used only to supply it. The reasoning heading, model checkmark, effort controls, and composer trigger remain available in the shared web/desktop picker.

Scope

A focused visual cleanup of the model picker, requested after encountering the redundant label during daily use. No provider, protocol, or native mobile behavior changes.

Verification

Proved in a task-isolated development server through the attached Browser panel: the same open picker shows the label before and only “Reasoning” after. Selected High, switched from Opus to Sonnet, and used Left Arrow to return focus to search; selection, effort controls, and keyboard navigation still work. A Replay (dev) turn also completed in the isolated environment.

vp run check:changed passed format, lint, knip, affected typechecks, 4 neighboring test files (9 tests), and React Compiler checks. No new test for this visual-only change, per repository guidance.

Before After
Before: repeated model name beside Reasoning After: Reasoning heading without repeated model name

Created with GPT-6.1 Sol in T3 Code through the Codex harness.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Nov 19, 2026
@coderabbitai

coderabbitai Bot commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The docked picker no longer shares a model label through DockedPickerContext or renders that label in the effort-column header. The docked layout, keyboard handler, and footer remain.

Changes: Docked picker label

Layer / File(s) Summary
Remove shared model label
apps/web/src/components/chat/ProviderModelPicker.tsx, apps/web/src/components/chat/ComposerModelEffort.tsx
The picker removes DockedPickerContext and its provider. The effort column no longer reads or displays the model label.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Refactor · Severity of issue fixed: Low

Possibly related issues

Possibly related PRs

  • pingdotgg/t3code#28069: This PR describes the same removal of the duplicate model label and its unused picker context.

Suggested reviewers: t3dotgg, juliusmarminge, macroscopeapp

Merge Risk: Minimal · up to 4e0bf

This is a small visual change to the model picker that removes a repeated model name beside the Reasoning heading. No behavior regression is evident, and the risk of merging is minimal.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: removing the repeated model name from the reasoning header in the model picker. It follows the conventional commit format and matches the raw summary and PR objectives…
Description check Passed The description follows the template. It has Problem, Change, Scope, and Verification sections. The Problem section states the cluttered repeated model label. The Change section lists the removed head…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: removing the repeated model name from the reasoning header in the model picker. It follows the conventional commit format and matches the raw summary and PR objectives. The title is specific and accurate.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, Scope, and Verification sections. The Problem section states the cluttered repeated model label. The Change section lists the removed header label and React context. The Scope section explains this is a visual cleanup and gives a reason it needs no linked issue, but it does not link an issue or a maintainer request. The Verification section gives manual browser checks, the check command result, and before/after screenshots, and it states that no new test was added. Minor gaps: no linked issue, and the template's agent-model line is present but relies on the author's own statement.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between bb23422 and 4e0bf2c.

Files selected for processing: 2

  • apps/web/src/components/chat/ComposerModelEffort.tsx
  • apps/web/src/components/chat/ProviderModelPicker.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge

Copy link
Copy Markdown
Member

it's not repeaated if u have a different tab open in the picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants