You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(web): home paths like ~/.claude/CLAUDE.md no longer show under the workspace folder - #39146
When an agent reads or edits a file in the user's home folder and reports the path as ~/..., the work log shows it as a file inside the project. A read of ~/.claude/CLAUDE.md in project demo is grouped as Read demo/~/.claude/CLAUDE.md. The edit row shows demo/~/.claude/CLAUDE.md. The expanded Read output joins the path to the workspace root (<workspace>/demo/~/.claude/CLAUDE.md), which is not a real file.
formatWorkspaceRelativePath and workEntryReadOutput treat any path that does not start with / and is not a Windows drive path as relative to the workspace. @t3tools/shared/path already has isHostPath, which also accepts ~/ and ~\. resolveWorkspaceFilePath already leaves those prefixes alone, because the server expands them. #38510 added ~\ to isHostPath so those paths open as home files.
Change
Both functions now use isHostPath instead of their own "starts with / or is a drive path" check. Home paths are shown as written, with \ normalised to / as before. Paths relative to the workspace and absolute paths behave the same as before.
Scope
Only ~/ and ~\ paths change. Windows drive-path display is untouched.
Opening a home-path link was already correct: the workspace lookup skips ~/ paths and the file panel accepts them through isHostPath. markdown-links.ts is not changed.
A bare ~ (no slash) is still treated as relative, matching isHostPath.
Verification
Regression tests come first, in commit 6bc342cf. On that commit alone, two assertions fail, showing t3code/~/.claude/CLAUDE.md and /workspace/t3code/~/.claude/CLAUDE.md. With the fix, filePathDisplay.test.ts, MessagesTimeline.logic.test.ts, markdown-links.test.ts and session-logic.runtime-diagnostics.test.ts pass (136 tests).
Real app: scripts/scenarios/home-path-tool-rows-show-as-written.e2e.ts (added with the tests) has a local ACP agent read and then edit ~/.claude/CLAUDE.md. I ran it with e2e run --target web on base 0c1cf54c and on this branch:
On base it fails: /~/ appears 3 times.
On this branch it passes: the path appears as written in both rows and in the Read output.
A path like ~/.claude/CLAUDE.md names a file in the user's home folder,
but the work log treats it as workspace-relative: the row label shows
t3code/~/.claude/CLAUDE.md and the expanded Read output shows
/workspace/t3code/~/.claude/CLAUDE.md. These tests fail on main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e workspace folder
formatWorkspaceRelativePath and workEntryReadOutput treated any path
that does not start with / or a drive letter as workspace-relative, so
~/ and ~\ paths got the workspace name or root put in front of them.
Both now use isHostPath, the shared helper that already counts home
paths as host paths, and leave those paths as written.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Reviewing files that changed from the base of the PR and between b776136 and 1334a1a.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
Trigger review
No actionable comments were generated in the recent review.
Walkthrough
Path display logic now uses isHostPath to preserve tilde-prefixed paths instead of joining them to the workspace root. Unit and end-to-end tests cover POSIX and Windows-style home paths.
Changes: Home path display
Layer / File(s)
Summary
Host-path detection and display validation apps/web/src/components/chat/MessagesTimeline.logic.ts, apps/web/src/components/chat/MessagesTimeline.logic.test.ts, apps/web/src/filePathDisplay.ts, apps/web/src/filePathDisplay.test.ts, scripts/scenarios/home-path-tool-rows-show-as-written.e2e.ts
Both display functions use isHostPath to determine whether to prefix paths with the workspace root. Tests cover relative paths and tilde-prefixed paths, including Windows-style separators. The end-to-end scenario checks that tool rows display ~/.claude/CLAUDE.md without a project prefix.
Home paths such as ~/.claude/CLAUDE.md are now shown as written instead of under the workspace folder. Other path display behavior is unchanged, and no merge-blocking risk was found.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the main change: home paths such as ~/.claude/CLAUDE.md no longer display under the workspace folder. It follows the conventional commit format and matches the code changes to formatWo…
Description check
The description follows the template. It covers the problem, the change, scope, and verification. It states the regression tests, the e2e scenario results on base and on the branch, and the checks run…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the main change: home paths such as ~/.claude/CLAUDE.md no longer display under the workspace folder. It follows the conventional commit format and matches the code changes to formatWorkspaceRelativePath and workEntryReadOutput, which now use isHostPath.
Full details: Description check
Explanation
The description follows the template. It covers the problem, the change, scope, and verification. It states the regression tests, the e2e scenario results on base and on the branch, and the checks run on Windows 11. It also lists what was not checked. It has no Problem sentence about the expected behavior in a separate line, but the problem section states it. The Scope section links no issue and does not cite a maintainer request. It gives a reason for the missing issue link only indirectly, so the scope section is partly incomplete. The verification section includes before/after images. It also names the agent and model, as the template requests.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.
Created demo/src/app.ts, replayed three Reads and one home-file Edit, then expanded the completed turn, file group, and first Read in the real web client. Both runs used fresh databases, Chromium, 1280×800, and light theme.
Four /~/ occurrences; home Reads and Edit incorrectly appear under demo.
Zero /~/ occurrences; ~/.claude/CLAUDE.md and ~/.gitconfig display correctly.
The before capture replaces only the absolute synthetic workspace prefix with for privacy. The incorrect demo/~/ suffix remains visible. The workspace-relative control remains demo/src/app.ts on both sides.
…ltas (#453)
* feat(native): port #444 Part B Sidebar, Thread & Transcript parity deltas
Port all remaining Sidebar, Thread View, and Transcript parity deltas from upstream `4121b30..80cf4f7` and flip `TV-LINEAGE` and `TR-WORK` to `done` in `apps/native/parity/LEDGER.md`.
Sidebar (`SB-ROW`, `SB-SECTIONS`, `SB-MENU`, `SB-UNDO`, `SB-SEARCH`, `SB-GROUPING`):
- Regenerating title glimmer (`pingdotgg#29383`)
- Settle-undo position restore via `plan_undo_for_thread` + `UnsettleRestore`/`ReorderActive` (`pingdotgg#33248`)
- Clear opened failed badge in sidebar rows and collapsed folder dots (`pingdotgg#28616`)
- Suppress `Done` badge for stopped/interrupted/cancelled runs (`pingdotgg#37475`)
- 1h snooze clock-minute rounding (`pingdotgg#36785`)
- Opening a delegated task selects its listed parent ancestor (`pingdotgg#37500`)
- Side-chat children included in worktree deletion check (`pingdotgg#36800`)
- Failed message search error state in sidebar search and command palette (`pingdotgg#38155`)
- Jump-hint modifier recheck after hold delay (`pingdotgg#38545`)
- Command palette `Failed` status pill prioritized over background `Waiting` (`pingdotgg#38968`)
Thread & Transcript (`TV-HISTORY`, `TV-LINEAGE`, `TV-FOLLOW`, `TR-WORK`, `TR-MARKDOWN`, `TR-CITE`, `TR-MCPAPP`):
- Subagent history model preservation via `merge_older_subagents` (`pingdotgg#38724`) and hide Resume when `supportsNativeResume` is false without an unsent continuation source (`pingdotgg#39229`)
- Cancel active smooth scroll in `keep_end` so finished-while-away threads open at end (`pingdotgg#38963`)
- MCP PR/CI work-log rows & summaries (`pingdotgg#26751`, `pingdotgg#26752`) and Windows `pwsh`/`powershell`/`cmd` launcher unwrapping (`pingdotgg#38946`)
- Leading-space user markdown preservation (`pingdotgg#38079`), RTL `<details>` and template cards (`pingdotgg#36876`, `pingdotgg#36922`), `Cite` on `send_to_user` rows (`pingdotgg#36858`), home/host paths out of workspace folder (`pingdotgg#39146`), and code/list/email copy serialization fixes (`pingdotgg#36712`, `pingdotgg#36830`, `pingdotgg#36867`, `pingdotgg#36915`, `pingdotgg#37284`, `pingdotgg#39150`)
- MCP app content-block filtering for stripped images (`pingdotgg#31338`), teardown generation race test (`pingdotgg#30387`), and pre-query/fragment download filename derivation (`pingdotgg#30712`)
* fix(native): address PR #453 review findings
Address all 3 review findings from `@d1-reviewer` (`pingdotgg#847`):
1. Remove unwired DOM-HTML Markdown re-serialization helpers (`wrap_inline_code`, `serialize_markdown_anchor`, `escape_markdown_prose`, `ListCopyItem`, `serialize_list_slice`) from `crates/core/src/markdown/clipboard.rs` and update `TR-MARKDOWN` in `apps/native/parity/LEDGER.md` accurately.
2. Add `restore_preserved_leading_whitespace` and wire `user_markdown_view` with a `Copy` (`Cmd+C`) action interceptor (`crates/app/src/transcript/markdown.rs`, `messages.rs`) so user-message Copy and Cite restore ASCII spaces/tabs while preserving literal user-typed NBSPs (`pingdotgg#38079`), verified by GPUI test `user_markdown_copy_restores_leading_spaces_and_preserves_literal_nbsp`.
3. Fetch omitted family side chats via `fetch_family_side_chats` alongside `ORCHESTRATION_GET_WORKTREE_THREAD_IDS` in `delete_thread_then` (`crates/app/src/sidebar/controller.rs`, `pingdotgg#36800`) before calling `has_other_worktree_occupants`, verified by GPUI test `worktree_cleanup_prompt_excludes_omitted_family_side_chats` (and fixed `late_teardown_does_not_close_replacement_host` under `--features snapshot` in `transcript/mcp_app.rs`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size:L100-499 changed lines (additions + deletions).vouch:unvouchedAuthor is not yet trusted in the VOUCHED list.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When an agent reads or edits a file in the user's home folder and reports the path as
~/..., the work log shows it as a file inside the project. A read of~/.claude/CLAUDE.mdin projectdemois grouped asRead demo/~/.claude/CLAUDE.md. The edit row showsdemo/~/.claude/CLAUDE.md. The expanded Read output joins the path to the workspace root (<workspace>/demo/~/.claude/CLAUDE.md), which is not a real file.formatWorkspaceRelativePathandworkEntryReadOutputtreat any path that does not start with/and is not a Windows drive path as relative to the workspace.@t3tools/shared/pathalready hasisHostPath, which also accepts~/and~\.resolveWorkspaceFilePathalready leaves those prefixes alone, because the server expands them. #38510 added~\toisHostPathso those paths open as home files.Change
Both functions now use
isHostPathinstead of their own "starts with/or is a drive path" check. Home paths are shown as written, with\normalised to/as before. Paths relative to the workspace and absolute paths behave the same as before.Scope
~/and~\paths change. Windows drive-path display is untouched.~/paths and the file panel accepts them throughisHostPath.markdown-links.tsis not changed.~(no slash) is still treated as relative, matchingisHostPath.Verification
6bc342cf. On that commit alone, two assertions fail, showingt3code/~/.claude/CLAUDE.mdand/workspace/t3code/~/.claude/CLAUDE.md. With the fix,filePathDisplay.test.ts,MessagesTimeline.logic.test.ts,markdown-links.test.tsandsession-logic.runtime-diagnostics.test.tspass (136 tests).scripts/scenarios/home-path-tool-rows-show-as-written.e2e.ts(added with the tests) has a local ACP agent read and then edit~/.claude/CLAUDE.md. I ran it withe2e run --target webon base0c1cf54cand on this branch:/~/appears 3 times.vp run check:changed(Windows): format, lint, knip, typecheck, tests (4 files) and the React Compiler check all pass.Not checked:
~/path in the real app. They go through the sameformatWorkspaceRelativePath, so only the unit test covers them.Found by Gemini 4 Neon in Antigravity. Implementation, evidence and review: Claude Opus 5.5 in Claude Code, directed by @SoroushRF.
🤖 Generated with Claude Code