Repository navigation
fix(web): copying items within one list keeps their list markers - #39150
juliusmarminge merged 17 commits into
Conversation
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ries Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-authored-by: GPT 6.2 Sol <codex@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
EvidenceWeb app, Chromium, 1280×800, light theme; fresh synthetic data on both commits. Open a thread containing 1. Install, 2. Configure, 3. Deploy. Select Configure through Deploy, copy, and paste into the empty composer. The scenario fails on base and passes on head: base pastes unnumbered lines; head retains numbers 2 and 3. Head also retains the selected list structure in copied Markdown and HTML.
|
…ltas (#453) * feat(native): port #444 Part B Sidebar, Thread & Transcript parity deltas Port all remaining Sidebar, Thread View, and Transcript parity deltas from upstream `4121b30..80cf4f7` and flip `TV-LINEAGE` and `TR-WORK` to `done` in `apps/native/parity/LEDGER.md`. Sidebar (`SB-ROW`, `SB-SECTIONS`, `SB-MENU`, `SB-UNDO`, `SB-SEARCH`, `SB-GROUPING`): - Regenerating title glimmer (`pingdotgg#29383`) - Settle-undo position restore via `plan_undo_for_thread` + `UnsettleRestore`/`ReorderActive` (`pingdotgg#33248`) - Clear opened failed badge in sidebar rows and collapsed folder dots (`pingdotgg#28616`) - Suppress `Done` badge for stopped/interrupted/cancelled runs (`pingdotgg#37475`) - 1h snooze clock-minute rounding (`pingdotgg#36785`) - Opening a delegated task selects its listed parent ancestor (`pingdotgg#37500`) - Side-chat children included in worktree deletion check (`pingdotgg#36800`) - Failed message search error state in sidebar search and command palette (`pingdotgg#38155`) - Jump-hint modifier recheck after hold delay (`pingdotgg#38545`) - Command palette `Failed` status pill prioritized over background `Waiting` (`pingdotgg#38968`) Thread & Transcript (`TV-HISTORY`, `TV-LINEAGE`, `TV-FOLLOW`, `TR-WORK`, `TR-MARKDOWN`, `TR-CITE`, `TR-MCPAPP`): - Subagent history model preservation via `merge_older_subagents` (`pingdotgg#38724`) and hide Resume when `supportsNativeResume` is false without an unsent continuation source (`pingdotgg#39229`) - Cancel active smooth scroll in `keep_end` so finished-while-away threads open at end (`pingdotgg#38963`) - MCP PR/CI work-log rows & summaries (`pingdotgg#26751`, `pingdotgg#26752`) and Windows `pwsh`/`powershell`/`cmd` launcher unwrapping (`pingdotgg#38946`) - Leading-space user markdown preservation (`pingdotgg#38079`), RTL `<details>` and template cards (`pingdotgg#36876`, `pingdotgg#36922`), `Cite` on `send_to_user` rows (`pingdotgg#36858`), home/host paths out of workspace folder (`pingdotgg#39146`), and code/list/email copy serialization fixes (`pingdotgg#36712`, `pingdotgg#36830`, `pingdotgg#36867`, `pingdotgg#36915`, `pingdotgg#37284`, `pingdotgg#39150`) - MCP app content-block filtering for stripped images (`pingdotgg#31338`), teardown generation race test (`pingdotgg#30387`), and pre-query/fragment download filename derivation (`pingdotgg#30712`) * fix(native): address PR #453 review findings Address all 3 review findings from `@d1-reviewer` (`pingdotgg#847`): 1. Remove unwired DOM-HTML Markdown re-serialization helpers (`wrap_inline_code`, `serialize_markdown_anchor`, `escape_markdown_prose`, `ListCopyItem`, `serialize_list_slice`) from `crates/core/src/markdown/clipboard.rs` and update `TR-MARKDOWN` in `apps/native/parity/LEDGER.md` accurately. 2. Add `restore_preserved_leading_whitespace` and wire `user_markdown_view` with a `Copy` (`Cmd+C`) action interceptor (`crates/app/src/transcript/markdown.rs`, `messages.rs`) so user-message Copy and Cite restore ASCII spaces/tabs while preserving literal user-typed NBSPs (`pingdotgg#38079`), verified by GPUI test `user_markdown_copy_restores_leading_spaces_and_preserves_literal_nbsp`. 3. Fetch omitted family side chats via `fetch_family_side_chats` alongside `ORCHESTRATION_GET_WORKTREE_THREAD_IDS` in `delete_thread_then` (`crates/app/src/sidebar/controller.rs`, `pingdotgg#36800`) before calling `has_other_worktree_occupants`, verified by GPUI test `worktree_cleanup_prompt_excludes_omitted_family_side_chats` (and fixed `late_teardown_does_not_close_replacement_host` under `--features snapshot` in `transcript/mcp_app.rs`).
…gdotgg#39150) Co-authored-by: Julius Marminge <julius0216@outlook.com> (cherry picked from commit ff9efe8)




On web and desktop, copying several items within a chat list dropped their numbers or bullets because the selection cloned the items without their list. Copied Markdown and HTML now keep the list and its displayed numbering, omitting empty items at the edges of selections that cross nested lists or continue into surrounding text. Copied Markdown also keeps the first selected task item's checkbox state when the selection starts at its label.
Fixes #39149
Related: #22035
Reproduction on main
Commit 470ca63499 (main). The pasted items appear as unnumbered text. The cause is at
apps/web/src/markdown-clipboard.ts:514. Ranpnpm scenarios:prove scripts/scenarios/copied-items-within-numbered-list-keep-numbers.e2e.ts --base mainwith the repro test added: it failed in 2 of 2 runs on a clean checkout, withThe pasted items keep their displayed list numbersin the output.Evidence
Environment: boat.dev default machine, Linux x64, a fresh checkout of each commit
Steps: Copying two items within a numbered list keeps their numbers: app.open ; expect.not.toHaveURL //pair(?:[?#]|$)/; app.open /86c0d370-69d0-42b1-bc7a-a286d0ba49a6/mcp:0cb7b251-113b-4c7d-b674-743ace323b9d; locator.tap getByRole("button", name: /^Agent Steps/); locator.waitFor getByText("Configure") → visible; browser.evaluate ; browser.keyboard.press ControlOrMeta+C; locator.tap getByRole("textbox"); browser.keyboard.press ControlOrMeta+V; browser.evaluate ; app.screenshot pasted-list-items; browser.evaluate .
Proven: the scenario fails on base 6dc7fdc8e8 and passes on head dc4627cde7.
Scenario source:
scripts/scenarios/copied-items-within-numbered-list-keep-numbers.e2e.tsTests
cd apps/web && pnpm exec vp test run src/components/ChatMarkdown.browser.test.tsx -t "with the markers its list shows"passed on head.pnpm exec vp run check:changedpassed on head.Not in this change
Who did the work
Made in T3 Code by Claude Opus 5.5 and GPT 6.2 Sol