Skip to content

fix(web): the terminal button reopens the drawer after its last terminal closed - #39260

Merged
juliusmarminge merged 4 commits into
pingdotgg:mainfrom
viktorce:fix/terminal-reopen-two-clicks
Nov 19, 2026
Merged

juliusmarminge merged 4 commits into
pingdotgg:mainfrom
viktorce:fix/terminal-reopen-two-clicks

Conversation

@viktorce

Copy link
Copy Markdown
Contributor

Problem

After you close the last terminal in a thread, the next click on the terminal button opens the drawer and closes it again about 20 ms later. A second click works. Steps are in #39259.

The terminal store remembers which terminal ids the server last listed (serverObservationsByThreadKey), and closes a local terminal that later drops off that list. A terminal you closed yourself stayed on the list, because the drawer unmounts before it sees the server drop the id. Reopening creates the same id (term-1), and the first reconcile treated it as closed elsewhere.

Change

When the client places a terminal id it doesn't already have, that id leaves the list. Whatever put it there, that listing is older than the new terminal, so it is about an earlier one. The next reconcile lists the id again if the server has it, so a terminal another client closes later still leaves the drawer.

This one rule covers the drawer unmounting right after the close, the drawer seeing the closing terminal once more during its close animation, and an entry saved in localStorage before this fix.

Scope

Fixes #39259, a regression from #38998.

Verification

  • The store test gets two rows, one where the drawer unmounts right after the close and one where it lists the closing terminal once more first. Both fail on main with expected false to be true and pass with the fix.
  • vp run scenarios:prove with an uncommitted scenario (open a terminal, close it with the trash icon, click the terminal button once) fails on base e37e45fd5b and passes on the fix.
  • vp run check:changed passes.

Before: the first click on the terminal button does nothing, the second opens the drawer.

terminal-reopen-before.mp4

After: the first click opens the drawer.

terminal-reopen-after.mp4

Not checked: the mobile app, which has no copy of this store logic, and remote or relay connections.

Implemented by Claude Opus 5.5 in Claude Code (running in T3 Code). Reviewed by Claude Fable 5.2 and GPT-6.1 Sol.

🤖 Generated with Claude Code

…nal closed

The terminal store remembers which terminal ids the server last listed, and
closes a local terminal that later drops off that list. A terminal the user
closed stayed on it, because the drawer unmounts before it sees the server
drop the id. Reopening the drawer creates the same id, and the first
reconcile closed it again.

A closed id now leaves the list when it closes, and stays off it while it is
still closing.
The store forgot a closed id at close time and kept it out of later
reconciles. An id saved by an older build never went through either path,
so its first reopen still took two clicks. Placing a fresh local id now
drops it from the observed list instead, which covers the close, the close
animation and the saved entry with one rule.
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

Commits

Reviewing files that changed from the base of the PR and between b7ba5aa and 85b1162.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The terminal UI store now clears a stale server observation when an absent terminal is unsuppressed. Regression tests cover reopening the default terminal after closing it, including when a stale reconciliation occurs first.

Changes: Terminal reopening

Layer / File(s) Summary
Clear stale terminal observations
apps/web/src/terminalUiStateStore.ts, apps/web/src/terminalUiStateStore.test.ts
When an unsuppressed terminal ID is absent from the thread’s UI state, the store removes it from the observed server IDs. Tests verify that reopening the default terminal keeps the drawer open after an empty server reconciliation, with and without an earlier stale reconciliation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Possibly related PRs

  • pingdotgg/t3code#28614: Changes terminal drawer state and controls, which overlap with the drawer behavior addressed here.
  • pingdotgg/t3code#38998: Changes terminal session reconciliation and the drawer state after the last terminal closes.

Suggested labels: bugfix

Suggested reviewers: stienswout, only21mil, maria-rcks

Merge Risk: Minimal · previous review b7ba5

This fixes the terminal drawer closing shortly after the first reopen. The change is small and covered by regression tests. No remaining merge-blocking risk is identified.

Pre-merge checks: Passed 3 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Linked Issues check Inconclusive Directly linked issue #39259 requires that, after the last terminal is closed, the next click on the terminal button opens the drawer with a new terminal. The cause is that a reused id (term-1) stay… Make the changed blobs for apps/web/src/terminalUiStateStore.ts and apps/web/src/terminalUiStateStore.test.ts available to the checkout, or provide a narrower read of the updateTerminal and forgetObservedTerminalId hunks. Then confi…
Passed Passed checks: 3 passed

Check name Status Explanation
Title check Passed The title states the main change: the terminal button no longer reopens the drawer after the last terminal was closed. It follows the conventional commit format and matches the fix in terminalUiStateS…
Description check Passed The description follows the template. It covers Problem, Change, Scope (links #39259 and a regression from #38998), and Verification with focused store tests, a scenario proof, and before/after record…
Out of Scope Changes check Passed The PR summary lists changes only in apps/web/src/terminalUiStateStore.ts (+34/-1) and apps/web/src/terminalUiStateStore.test.ts (+19/-0). Both files hold the terminal UI state logic named in #392…
Full details: Title check

Explanation

The title states the main change: the terminal button no longer reopens the drawer after the last terminal was closed. It follows the conventional commit format and matches the fix in terminalUiStateStore. It is specific and clear.

Full details: Description check

Explanation

The description follows the template. It covers Problem, Change, Scope (links #39259 and a regression from #38998), and Verification with focused store tests, a scenario proof, and before/after recordings. It also states what was not checked. The Problem section gives reproduction steps by reference to the linked issue, and the Change section explains the single rule and why it covers the cases. The template's agent attribution line is present. The description is complete.

Full details: Out of Scope Changes check

Explanation

The PR summary lists changes only in apps/web/src/terminalUiStateStore.ts (+34/-1) and apps/web/src/terminalUiStateStore.test.ts (+19/-0). Both files hold the terminal UI state logic named in #39259. The added helper forgetObservedTerminalId and the regression test relate directly to the reported stale-observation behavior. No unrelated files or features appear in the summary. The diff itself could not be read, so this verdict relies on the summary's file list and descriptions.

Full details: Linked Issues check

Explanation

Directly linked issue #39259 requires that, after the last terminal is closed, the next click on the terminal button opens the drawer with a new terminal. The cause is that a reused id (term-1) stays in serverObservationsByThreadKey after a local close, so the next reconcile closes the reopened terminal. The PR summary describes a fix in apps/web/src/terminalUiStateStore.ts: forgetObservedTerminalId runs in updateTerminal when an unsuppressed terminal is absent from existing UI state, and a new regression test in apps/web/src/terminalUiStateStore.test.ts covers the unmount and closing-animation cases. The repository diff could not be read because the changed blobs are missing from the checkout. The head terminalUiStateStore.ts read was truncated before updateTerminal, so the new logic was not verified in source. The test results and the scenarios:prove run are author-reported only. The requirement is therefore not confirmed from code.

Resolution

Make the changed blobs for apps/web/src/terminalUiStateStore.ts and apps/web/src/terminalUiStateStore.test.ts available to the checkout, or provide a narrower read of the updateTerminal and forgetObservedTerminalId hunks. Then confirm that a fresh local id removes the stale observed id and that the regression test runs against the reviewed head.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 803f21f and b7ba5aa.

Files selected for processing: 2

  • apps/web/src/terminalUiStateStore.test.ts
  • apps/web/src/terminalUiStateStore.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

@juliusmarminge

Copy link
Copy Markdown
Member

Evidence

Chromium, 1280×800, light theme; fresh synthetic project and replay thread on each commit. Open the thread, open the terminal drawer, close its only terminal with the trash button and confirm, then click the terminal button exactly once.

Before After
Commit 106a1e03b7 85b11622d4
Result Drawer closes again; terminal absent New terminal remains open
After one reopen click Before: drawer closed After: terminal open
Final state Before: terminal still absent After: new shell remains open
Recording Before interaction After interaction

Scenario source. scenarios:prove exited 0: failed on base and passed on head.

@juliusmarminge juliusmarminge added takeover:ready Takeover done; auto-lands when gates pass and removed takeover:in-progress A takeover lead is working on this PR labels Nov 19, 2026
@juliusmarminge
juliusmarminge merged commit 80cf4f7 into pingdotgg:main Nov 19, 2026
56 checks passed
@juliusmarminge juliusmarminge removed the takeover:ready Takeover done; auto-lands when gates pass label Nov 19, 2026
github-actions Bot added a commit to omarcresp/t3code-flake that referenced this pull request Nov 19, 2026
**v0.1.11-nightly.20261119.4954** · 107 changes from 48 contributors

- **SSH with one-time codes.** Desktop SSH connections can reuse an existing sign-in on hosts requiring a one-time code.
- **Antigravity compaction.** Use /compact in Antigravity sessions that support it.
- **Revert after delegation.** Use Revert files too after subagents finish, even when their chats are retained.
- **Steer Antigravity.** Send steering messages without stopping running subagents.
- **Terminal shortcuts.** Use Ctrl+B in the terminal on Linux and Windows, including as the default tmux prefix.
- **Scheduled task branches.** Tasks created in Settings now run from the project's default branch, even when it isn't main.
- **Offline Connect environments.** Saved T3 Connect environments are preserved when the desktop app starts offline.

### Plus 96 more bug fixes and performance improvements.

<details>
<summary>Full changelog</summary>

## What's Changed
* fix(provider-acp): an ACP compaction no longer keeps a summary its agent cleared by @SoroushRF in pingdotgg/t3code#39151
* fix(provider-acp): a running tool shows the file a location-only update names by @SoroushRF in pingdotgg/t3code#39147
* fix(server): wake when CI fails during the PR watch baseline read by @tiborrr in pingdotgg/t3code#39116
* fix(mobile): new-task link no longer blanks a scheduled task while it saves by @StiensWout in pingdotgg/t3code#39154
* fix(web): the Compact chip no longer shows after /clear by @viktorce in pingdotgg/t3code#39133
* fix(mobile): cancelling a model download keeps the current transcription model by @StiensWout in pingdotgg/t3code#39157
* fix(server): steering an Antigravity turn no longer stops its subagents by @Codder13 in pingdotgg/t3code#39165
* perf(server): read issue tracker bindings once per listing by @Adamulek123 in pingdotgg/t3code#39169
* fix(mobile): a changed-file pick no longer resets an earlier diff of the same PR by @StiensWout in pingdotgg/t3code#39171
* fix(ssh): connect when ~/.t3 is a symlink to a missing directory by @juliusmarminge in pingdotgg/t3code#39184
* perf(linear): skip issue descriptions when loading list rows by @Adamulek123 in pingdotgg/t3code#39180
* fix(server): storage cleanup names a broken Git ref and fetches it once per sweep by @juliusmarminge in pingdotgg/t3code#39202
* perf(linear): skip viewer lookup for comments without reactions by @Adamulek123 in pingdotgg/t3code#39189
* fix(server): self-settle survives a delegated wake cancelled before it started by @juliusmarminge in pingdotgg/t3code#39221
* fix(client-runtime): hide Resume where the provider cannot continue a stopped run by @juliusmarminge in pingdotgg/t3code#39229
* fix(web): zoom shortcuts zoom the app from the PR, Diff and Files panes by @jbearak in pingdotgg/t3code#39207
* fix(provider-acp-registry): a failed terminal sign-in shows what the login command printed by @juliusmarminge in pingdotgg/t3code#39238
* fix(desktop): Edit, Window, and context menu items follow the UI language by @panol in pingdotgg/t3code#39224
* fix(shared): theme CSS saves with escaped quotes and quoted comment markers by @SoroushRF in pingdotgg/t3code#39217
* test: pull request Code tab keeps a hidden test file open through collapse all by @StiensWout in pingdotgg/t3code#39213
* fix(cursor): models added to the account run in workspaces that already ran Cursor by @juliusmarminge in pingdotgg/t3code#39246
* fix(server): MCP delegation accepts models from the project's own provider config by @juliusmarminge in pingdotgg/t3code#39247
* fix(server): shell reads no longer walk a thread's finished tool calls by @navidnadali in pingdotgg/t3code#39235
* fix(mobile,web): quote and port messages are translated in every language by @panol in pingdotgg/t3code#39225
* fix(server): remove terminal styling from saved notebook outputs by @Lucenx9 in pingdotgg/t3code#39253
* fix(web): the terminal button reopens the drawer after its last terminal closed by @viktorce in pingdotgg/t3code#39260
* fix(server): failed background status fetches no longer leave partial packs by @juliusmarminge in pingdotgg/t3code#39264
* fix(acp): a late session/load response no longer leaves the session without model controls by @juliusmarminge in pingdotgg/t3code#23586
* fix(marketing): Japanese homepage copy reads naturally, with the same wording fixes in six more locales by @maria-rcks in pingdotgg/t3code#38947
* docs(mcp): document thread launch retries by @ChenCJ-io in pingdotgg/t3code#38842
* test(server): desktop upload test no longer races chromium's DevToolsActivePort write by @realsuiciniv in pingdotgg/t3code#38727
* fix(web): Ctrl+B reaches a focused terminal again by @sti0 in pingdotgg/t3code#34588
* perf(client-runtime): skip history scans when no runs are queued by @saphid in pingdotgg/t3code#25519
* fix(web): right-clicking a sidebar search result now opens its thread actions by @NawfalAhmed in pingdotgg/t3code#31545
* fix(mobile): long user messages collapse like on web by @BreadGenie in pingdotgg/t3code#34319
* fix(client-runtime): CamelCase account names get distinct badge initials by @Eightsheet in pingdotgg/t3code#35343
* fix(server): delegated completion wakes name the child thread by @juliusmarminge in pingdotgg/t3code#39297
* fix(server): preview_resize sizes hidden desktop tabs without a snapshot by @juliusmarminge in pingdotgg/t3code#39269
* fix(i18n): correct wrong and ambiguous Simplified Chinese strings by @loosekite in pingdotgg/t3code#37978
* fix(server): images that ACP agents read show a preview by @matthewcosier in pingdotgg/t3code#37468
* fix(antigravity): allow compaction when the runtime advertises it by @youjiaxing in pingdotgg/t3code#37020
* fix(ssh): report missing tar or gzip before downloading remote runtime by @bettercallcaleb in pingdotgg/t3code#35307
* fix(server): starting a native subagent no longer records a failed projection read span by @mInrOz in pingdotgg/t3code#39284
* fix: match dotted capital I in Find in Thread by @StiensWout in pingdotgg/t3code#39290
* fix(server): the HEAD watch no longer spawns Git in a removed worktree by @mInrOz in pingdotgg/t3code#39294
* fix(server): whole-word content searches no longer miss matching files by @juliusmarminge in pingdotgg/t3code#39285
* fix(web): scroll wide tables to the selected Find match by @StiensWout in pingdotgg/t3code#39295
* fix(web): an off-track desktop build no longer says "Up to date" by @juliusmarminge in pingdotgg/t3code#39302
* fix(server): native session replacement fails honestly when the provider reuses its session by @TinBane in pingdotgg/t3code#27517
* fix(server): repeated capture timeouts no longer delay turn starts by @voltcrash in pingdotgg/t3code#29196
* fix(server): restart recovery no longer reads every idle thread on a shared session by @Jolymmiles in pingdotgg/t3code#32396
* perf(server): avoid discarded history when retrieving remote task results by @Adamulek123 in pingdotgg/t3code#26664
* fix(triage): file labeled reports through the issue template by @pnupu in pingdotgg/t3code#31321
* fix(server): HTML reports in dot-prefixed folders no longer open as Not Found by @StiensWout in pingdotgg/t3code#38210
* fix(dev): avoid dependency-triggered server restarts on Windows by @nateEc in pingdotgg/t3code#38870
* fix(themes): keep escaped quotes in CSS text by @StiensWout in pingdotgg/t3code#39296
* fix(mobile,web): saves, account switches and registrations report their own outcome by @juliusmarminge in pingdotgg/t3code#38911
* fix(client): commands run as Effects on the caller's fiber, so interrupting a caller stops them by @juliusmarminge in pingdotgg/t3code#38912
* fix(mobile): device registration and Live Activity updates stay in Effect by @juliusmarminge in pingdotgg/t3code#38913
* fix(server): a stalled poll no longer stalls headless T3 Connect login by @elias1218 in pingdotgg/t3code#39214
* fix(acp-registry): keep managed npm commands out of user PATH by @StiensWout in pingdotgg/t3code#37542
* fix(server): denying a device that was already approved no longer reports success by @Umais-Adeed in pingdotgg/t3code#38420
* fix(server): MCP apps resume an idle Codex thread in its own workspace by @alextyhwang in pingdotgg/t3code#38468
* fix(web): preserve Connect environments on unreachable auth at launch by @juliusmarminge in pingdotgg/t3code#24642
* fix(server): gh credential lookups no longer leak D-Bus daemons by @juliusmarminge in pingdotgg/t3code#23824
* fix(shared): atomic saves preserve file modes and sync to disk by @juliusmarminge in pingdotgg/t3code#24310
* fix(claude): every repeated --plugin-dir launch argument loads its plugin by @Marve10s in pingdotgg/t3code#38634
* fix(server): request_secret opens a new card when a later run reuses a clientRequestId by @SvetlomirB in pingdotgg/t3code#38167
* fix(server): Codex goal turns after a server restart are paused instead of running unseen by @juliusmarminge in pingdotgg/t3code#25935
* fix(dev): dev runner never points a dev server at the live ~/.t3/userdata by @Lenoridev in pingdotgg/t3code#38807
* fix(server): keep Codex apps and plugins off during text generation by @Lucenx9 in pingdotgg/t3code#39086
* fix(web): a tool call's diff names its files relative to the workspace by @Entrpi in pingdotgg/t3code#32697
* fix(shared): T3 Connect no longer runs cloudflared releases that trust the compromised eMudhra intermediates by @Project516 in pingdotgg/t3code#26040
* fix(evals): GPT evals use the configured Codex provider and CODEX_HOME by @juliusmarminge in pingdotgg/t3code#38573
* fix(pi): Pi agents get T3's pull request linking rules by @yilmazff in pingdotgg/t3code#31727
* fix(server): t3_thread_launch refuses a defaulted worktree launch when Git cannot read HEAD by @juliusmarminge in pingdotgg/t3code#38459
* fix(server): let parents revert after their subagents complete by @Kwan-Li in pingdotgg/t3code#31874
* fix(server): t3_project_create names the link that refuses it and rejects a model default it would drop by @juliusmarminge in pingdotgg/t3code#30471
* fix(server): Full access rejects Claude Code's reworded dangerous-removal check by @juliusmarminge in pingdotgg/t3code#38581
* fix(source-control-github): sign out an app sign-in GitHub refuses to refresh for the client's credentials by @juliusmarminge in pingdotgg/t3code#39048
* fix(web): preserve newer project action drafts when imports fail by @StiensWout in pingdotgg/t3code#39312
* fix(server): Codex thread name follows T3 thread renames by @pauldupuyjr in pingdotgg/t3code#37442
* fix(server): Antigravity 1.5 temporary setup and text-helper sessions clean up their files by @MusseJusse in pingdotgg/t3code#39275
* fix(server): a provider CLI that dies at startup names its exit and EPERM by @juliusmarminge in pingdotgg/t3code#39299
* fix(web): scope Git controls to the active checkout by @StiensWout in pingdotgg/t3code#39305
* fix: index displayed file line ranges in thread search by @StiensWout in pingdotgg/t3code#39308
* fix(server): storage cleanup removes clean detached worktrees whose commits are on a branch by @juliusmarminge in pingdotgg/t3code#34967
* fix(server): a delivered handoff of a failed run is not re-sent to later fresh sessions by @juliusmarminge in pingdotgg/t3code#39281
* fix(mobile): a thread's goal pill can be cleared or resumed by @juliusmarminge in pingdotgg/t3code#39283
* fix(web,mobile): scheduled tasks from Settings start from the project's default branch by @binjamshid in pingdotgg/t3code#32841
* fix(web): keep deleted ACP sessions out of pending listings by @StiensWout in pingdotgg/t3code#39331
* fix(server): keep Antigravity thread cwd in workspace by omitting attachmentsDir from additionalDirectories by @helmipradita in pingdotgg/t3code#37997
* fix(server): a secret card closes after the steering restart that supersedes it by @Ali-Al1 in pingdotgg/t3code#34634
* fix(web): keep sidebar update status readable at narrow widths by @shivamhwp in pingdotgg/t3code#39227
* fix(web): keep SSH connection checks pending until they finish by @StiensWout in pingdotgg/t3code#39328
* fix(server): /logout in chat needs providers:manage by @juliusmarminge in pingdotgg/t3code#39027
* fix(ssh): desktop SSH reaches hosts with a one-time code through a signed-in ControlMaster by @juliusmarminge in pingdotgg/t3code#30616
* fix(pi): T3 tools are callable by Pi's own mcp__t3_code__ names by @juliusmarminge in pingdotgg/t3code#26845
* fix(server): agents on hosts without swap are OOM-killed instead of throttled for hours by @juliusmarminge in pingdotgg/t3code#39287
* fix(server): threads stay in Working when Claude or OpenCode marks a background wait between turns by @Bil0000 in pingdotgg/t3code#38638
* fix(web): collapse extra linked issues in thread details by @Bil0000 in pingdotgg/t3code#39232
* fix(release): update feed check waits for a just-published nightly by @t3dotgg in pingdotgg/t3code#39192
* perf(server): turn start reads a long thread's restart-note history once by @juliusmarminge in pingdotgg/t3code#39241
* fix(web): Cmd+W closes the browser tab when the page has focus by @Ernest0-Production in pingdotgg/t3code#39340
* fix(server): agents can tell another agent's message from the user's by @Bil0000 in pingdotgg/t3code#39306

## New Contributors
* @tiborrr made their first contribution in pingdotgg/t3code#39116
* @Codder13 made their first contribution in pingdotgg/t3code#39165
* @jbearak made their first contribution in pingdotgg/t3code#39207
* @panol made their first contribution in pingdotgg/t3code#39224
* @realsuiciniv made their first contribution in pingdotgg/t3code#38727
* @BreadGenie made their first contribution in pingdotgg/t3code#34319
* @Eightsheet made their first contribution in pingdotgg/t3code#35343
* @loosekite made their first contribution in pingdotgg/t3code#37978
* @youjiaxing made their first contribution in pingdotgg/t3code#37020
* @bettercallcaleb made their first contribution in pingdotgg/t3code#35307
* @alextyhwang made their first contribution in pingdotgg/t3code#38468
* @SvetlomirB made their first contribution in pingdotgg/t3code#38167
* @yilmazff made their first contribution in pingdotgg/t3code#31727
* @Kwan-Li made their first contribution in pingdotgg/t3code#31874
* @pauldupuyjr made their first contribution in pingdotgg/t3code#37442
* @MusseJusse made their first contribution in pingdotgg/t3code#39275

**Full Changelog**: pingdotgg/t3code@v0.1.11-nightly.20261119.4941...v0.1.11-nightly.20261119.4954

</details>


Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.1.11-nightly.20261119.4954
rynfar added a commit to rynfar/t3code that referenced this pull request Nov 20, 2026
…zone, and panel animations (#454)

* feat(native): restore parity for terminal, preview, keybindings, timezone, and panel animations

Implements the #442 and #1 parity deltas across Terminal, Preview, Keybindings, General timezone refresh, and Appearance panel animations:

- Terminal (PN-TERMINAL -> done): optional `confirmTerminalClose` setting and confirmation bypass (`pingdotgg#35305`), shell startup error replay (`pingdotgg#37088`), serialized >64KB chunked pastes with bracketed-paste recovery (`pingdotgg#37103`), bare compiler links, server hostname `file://` URIs, and numeric filename suffixes (`pingdotgg#37071`, `pingdotgg#37133`, `pingdotgg#37201`), OSC 10/11 color & focus reporting (`pingdotgg#36777`, `pingdotgg#37066`), legacy binary mouse reports & fractional hit-testing (`pingdotgg#37148`, `pingdotgg#37223`), single-viewer PTY query `reply: true` (`pingdotgg#37233`), keypad NumLock & modified F3 (`pingdotgg#37175`, `pingdotgg#37211`), concealed text, cursor decorations & color repaints (`pingdotgg#37141`, `pingdotgg#37206`, `pingdotgg#37193`), and remote-close background terminal drop & drawer reopen (`pingdotgg#38998`, `pingdotgg#39260`).
- Preview (PN-PREVIEW clears #390/#442): `/api/preview/tunnel` `LoopbackTunnel` SOCKS5 bridge & external system-browser URL rewriting (`pingdotgg#37948`), 10s no-frames Chromium stalled alert (`pingdotgg#38865`), and `Preview`-scoped zoom shortcuts (`pingdotgg#39207`).
- Keybindings & General (KB-USER -> done, KB-DEFAULTS, ST-GENERAL clears #442): unassign default shortcuts via `when: "false"` (`pingdotgg#28687`), `PageUp`/`PageDown` labels (`pingdotgg#28319`), `Shift+F6` side-chat focus exit (`pingdotgg#31931`), right-panel shortcuts on unsent drafts (`pingdotgg#35189`), and live system timezone / `TZ` refresh (`pingdotgg#32371`).
- Appearance (ST-APPEARANCE -> done): `panelAnimationDurationMs` smooth transitions on `workspace.rs` left sidebar and `terminal/drawer.rs`.

* fix(native): remove unused preview loopback tunnel and guard external server URLs on private hosts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched Author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Terminal button needs two clicks after the last terminal was closed

2 participants