Repository navigation
fix(web): theme CSS shorthands with var() can no longer load remote files #39346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
elias1218
wants to merge
6
commits into
pingdotgg:main
from
elias1218:fix/theme-css-shorthand-var-fetch
+89
−9
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
01d4faa
fix(web): theme CSS shorthands with var() can no longer load remote f…
elias1218 93e80c4
Merge origin/main into fix/theme-css-shorthand-var-fetch
juliusmarminge 074fcb1
fix(web): keep empty custom properties when stripping var() shorthands
juliusmarminge c1ff1c3
fix(web): keep var() shorthands with an override when the theme canno…
juliusmarminge f6c2fd9
fix(web): an unrelated blocked url() no longer drops overridden var()…
juliusmarminge 993b47e
fix(web): env(), attr() and if() shorthands count as substitutions too
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the
env()regression at the shared unit layer.The new row in
packages/shared/src/themeCss.test.tsalready catches this source-classification regression. Remove this duplicate browser phase. Keep the existing browser coverage for CSSOM filtering and overridden shorthands.As per coding guidelines, “Test at one layer: the lowest one that fails on
main.” As per path instructions, “do not duplicate the same case across layers.”Sources: Coding guidelines, Path instructions