Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8124
Fix incorrect normalization of
contours.valuefor interval constraints.This causes cases such as:
This PR normalizes them as:
The issue is in constraint_defaults.js, where the array length is checked against
contours.lengthinstead ofcontours.value.length, and arrays longer than two values are handled withslice(2)instead ofslice(0, 2).The relevant logic is this part:
plotly.js/src/traces/contour/constraint_defaults.js
Lines 59 to 71 in 1ef3c78
This affects both
contourandcontourcarpet, since they share the same constraint defaults.