[btry]

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

Embodied impact and usage impact of a specific asset are not erased with the same query parameters. The PR harmonizes this.

Screenshots (if appropriate):

[Rom1-B]

tests/units/Controller/EmbodiedImpactControllerTest.php still posts id, so it now stops on the missing arguments check and never reaches the purge right check. Asserting the message makes that visible:

@@ -32,6 +32,7 @@
 namespace GlpiPlugin\Carbon\Tests\Controller;
 
+use Computer;
 use Glpi\Exception\Http\AccessDeniedHttpException;
@@ -127,13 +128,14 @@
         $request = Request::create('/', 'POST', [
-            'id' => '1',
+            'itemtype' => Computer::class,
+            'items_id' => '1',
         ]);
 
         $response = $this->callPrivateMethod(new EmbodiedImpactController(), 'reset', $request);
 
         $this->assertInstanceOf(RedirectResponse::class, $response);
-        $this->assertCount(1, $_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR]);
+        $this->assertSame([__('Reset denied.', 'carbon')], $_SESSION['MESSAGE_AFTER_REDIRECT'][ERROR]);

[Rom1-B]

Can you add a test resetting a real asset with itemtype/items_id and checking its embodied impact row is gone?

[Rom1-B]

calculate() still uses the old msgid, which is already translated; I'd keep it here and in UsageImpactController too:

Suggested change

	Session::addMessageAfterRedirect(__('Missing arguments in the request.', 'carbon'), false, ERROR);
	Session::addMessageAfterRedirect(__('Missing arguments in request.', 'carbon'), false, ERROR);