Repository navigation
Conversation
marifex
force-pushed
the
fix/values-lookup-itemtype
branch
from
October 21, 2026 15:22
e4f33bf to
2a3b62e
Compare
Rom1-B
requested changes
Oct 29, 2026
| - Fix `Yes/No` field values returned as strings instead of integers in search results | ||
| - Fix ticket observers being able to edit and save additional fields they are not allowed to modify | ||
| - Fix mandatory fields blocking ticket creation from a GLPI form. | ||
| - Fix slow display and save of items with additional fields when the values tables are large |
Contributor
There was a problem hiding this comment.
1.24.7 is already released and this PR now conflicts with 11.0/bugfixes: can you rebase and move this entry to a new ## [Unreleased] section?
Author
There was a problem hiding this comment.
Rebased on 11.0/bugfixes and moved the entry to a new Unreleased section.
marifex
force-pushed
the
fix/values-lookup-itemtype
branch
from
October 29, 2026 10:53
2a3b62e to
b6b185b
Compare
Rom1-B
approved these changes
Oct 29, 2026
Rom1-B
left a comment
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
A regression test would still be welcome: a values row with the same items_id but another itemtype, checking that stored values are read and purged only for the right itemtype.
RomainLvr
approved these changes
Oct 29, 2026
MyvTsv
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
items_id(andplugin_fields_containers_id), so they cannot use theitemtype_item_containerunique index, which starts withitemtype, and do a full scan of the table. On large tables this slows down the display and the save of every item with additional fields. The lookups and the delete on purge now also filter onitemtype.