Repository navigation
Allow marking an already closed patch as committed - #129
Merged
Merged
Conversation
When a patch in the open commitfest was already closed, for example as "Returned with feedback", and a committer then marked it as committed, this crashed with `UserInputError: Patch in state Returned with feedback cannot be moved.`. The "committed" action first moves the patch to the in progress commitfest (or from the draft to the regular open commitfest) so that it gets recorded in the commitfest it was actually committed in, but `Patch.move()` refused to move closed patches. `Patch.move()` now takes an `allow_move_closed` argument, which the commit action passes. Because closed statuses require a leavedate, the new `PatchOnCommitFest` gets one when the patch it was moved from was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a patch in the open commitfest was already closed, for example as "Returned with feedback", and a committer then marked it as committed, this crashed with
UserInputError: Patch in state Returned with feedback cannot be moved.. The "committed" action first moves the patch to the in progress commitfest (or from the draft to the regular open commitfest) so that it gets recorded in the commitfest it was actually committed in, butPatch.move()refused to move closed patches.Patch.move()now takes anallow_move_closedargument, which the commit action passes. Because closed statuses require a leavedate, the newPatchOnCommitFestgets one when the patch it was moved from was closed.