Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220.
Subscriptionnow joins theWITH (...)options with commas. The connection string continues using spaces. Multiple options previously produced invalid SQL such asWITH (copy_data=False enabled=True).The existing real logical-replication test now supplies both
copy_data=Falseandenabled=Truewhen recreating a subscription, then verifies subsequent rows reach the subscriber. This also retains the no-option creation path earlier in the same test.Validation on macOS, Python 3.11 and PostgreSQL 16.15:
enabledon the original implementation for both local node configurations.pytest -q tests/test_testgres_common.py -k 'test_logical_replication and local': 2 passed, 2 skipped after the fix.Local tests used psycopg2-binary instead of compiling psycopg2. Remote nodes, the complete test suite and the multi-version PostgreSQL CI matrix were not run.