Repository navigation
Floxis: convert non-USD floors and request currency to USD - #4694
Open
floxis-admin wants to merge 2 commits into
Open
floxis-admin wants to merge 2 commits into
floxis-admin wants to merge 2 commits into
Conversation
CTMBNara
requested changes
Nov 2, 2026
Comment on lines
+432
to
+438
| final BidRequest bidRequest = givenBidRequest(imp -> imp | ||
| .bidfloor(BigDecimal.ONE) | ||
| .bidfloorcur("EUR") | ||
| .ext(givenImpExt("abc", "us-e"))) | ||
| .toBuilder() | ||
| .cur(singletonList("EUR")) | ||
| .build(); |
Collaborator
There was a problem hiding this comment.
Add givenBidRequest(UnaryOperator<BidRequest.Builder> bidRequestCustomizer, Imp.. imps) method and use it instead
Contributor
Author
There was a problem hiding this comment.
Done in db88417: added givenBidRequest(UnaryOperator<BidRequest.BidRequestBuilder> bidRequestCustomizer, Imp... imps), and the conversion test uses it.
Collaborator
There was a problem hiding this comment.
Test that cur array won't be changed if it contains USD
Contributor
Author
There was a problem hiding this comment.
Done in db88417: makeHttpRequestsShouldNotChangeRequestCurrencyWhenItContainsUsd sends cur ["EUR", "USD"] and expects it unchanged.
Collaborator
There was a problem hiding this comment.
I see some missed changes from GO version:
if len(seatBid.Bid[i].ADomain) > 0 {
typedBid.BidMeta = &openrtb_ext.ExtBidPrebidMeta{AdvertiserDomains: seatBid.Bid[i].ADomain}
}
Contributor
Author
…cy that already includes USD Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
floxis-admin
force-pushed
the
floxis-usd-floors
branch
from
November 3, 2026 20:42
f79768c to
db88417
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Floxis exchange bids in USD only and rejects requests that offer no USD. This updates the Floxis bidder (and its
adapexalias):CurrencyConversionService, andbidfloorcuris set toUSD. If the conversion fails, that impression is skipped with a bad-input error.curis set and does not include USD, the outgoing request setscurto["USD"]. Requests withoutcur, or already including USD, are unchanged.adomainis copied toext.prebid.meta.advertiserDomains, keeping any otherbid.extfields.FloxisBidderTest(31), theFloxisTestandAdapexTestITs and checkstyle pass.Go port: prebid/prebid-server#5066.
🤖 Generated with Claude Code