Repository navigation
Conversation
- Read bid.mtype (1 banner, 2 video) when it is set. - Fall back to the impression when mtype is absent. - Add tests for a banner + video impression with mtype 1, mtype 2 and without mtype.
- Declare audio and native media types for app and site. - Map bid.mtype 3 to audio and 4 to native. - Without mtype, fall back to the impression: video, then audio, then native, otherwise banner. - Add tests for audio and native bids, with and without mtype.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
The SmileWanted endpoint returns
bid.mtypeon its bids. The adapter now uses it to set the bid type, and supports audio and native.🧠 Rationale behind the change
bid.mtypesets the bid type when present: 1 banner, 2 video, 3 audio, 4 native.mtype, the bid type still comes from the impression (video, then audio, then native, otherwise banner).🧪 Test plan
mtype1, withmtype2 and withoutmtype.mtype.SmileWantedBidderTestpasses with 100% line and branch coverage ofSmileWantedBidder, checkstyle clean.🏎 Quality check