Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1298,10 +1298,15 @@ private Device makeDevice(Device device) {
return device == null
? null
: device.toBuilder()
.ext(mapper.fillExtension(
ExtDevice.of(ObjectUtil.getIfNotNull(device.getExt(), ExtDevice::getAtts), null),
MagniteDeviceExt.of(MagniteDeviceExtRp.of(device.getPxratio()))))
.build();
.ext(mapper.fillExtension(
ExtDevice.of(resolveAtts(device.getExt()), null),
MagniteDeviceExt.of(MagniteDeviceExtRp.of(device.getPxratio()))))
.build();
}

private static Integer resolveAtts(ExtDevice extDevice) {
final Integer atts = ObjectUtil.getIfNotNull(extDevice, ExtDevice::getAtts);
return (atts != null && atts >= 0 && atts <= 3) ? atts : null;
}

private Site makeSite(Site site, String impLanguage, ExtImpMagnite magniteImpExt) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2272,12 +2272,60 @@ public void makeHttpRequestsShouldFillDeviceExtIfDevicePresent() throws JsonProc
.containsOnly(mapper.readTree("4.2"));
}

@Test
public void makeHttpRequestsShouldDiscardNegativeAtts() {
// given
final BidRequest bidRequest = givenBidRequest(
builder -> builder.device(Device.builder()
.ext(ExtDevice.of(-1, null))
.build()),
builder -> builder.video(Video.builder().build()),
identity());

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.singleElement()
.extracting(HttpRequest::getPayload)
.extracting(BidRequest::getDevice)
.extracting(Device::getExt)
.extracting(ExtDevice::getAtts)
.isNull();
}

@Test
public void makeHttpRequestsShouldDiscardInvalidAtts() {
// given
final BidRequest bidRequest = givenBidRequest(
builder -> builder.device(Device.builder()
.ext(ExtDevice.of(4, null))
.build()),
builder -> builder.video(Video.builder().build()),
identity());

// when
final Result<List<HttpRequest<BidRequest>>> result = target.makeHttpRequests(bidRequest);

// then
assertThat(result.getErrors()).isEmpty();
assertThat(result.getValue())
.singleElement()
.extracting(HttpRequest::getPayload)
.extracting(BidRequest::getDevice)
.extracting(Device::getExt)
.extracting(ExtDevice::getAtts)
.isNull();
}

@Test
public void makeHttpRequestsShouldPreserveOnlyDeviceExtAtts() {
// given
final BidRequest bidRequest = givenBidRequest(
builder -> builder.device(Device.builder()
.ext(ExtDevice.of(1, ExtDevicePrebid.of(ExtDeviceInt.of(1, 1))))
.ext(ExtDevice.of(0, ExtDevicePrebid.of(ExtDeviceInt.of(1, 1))))
.build()),
builder -> builder.video(Video.builder().build()),
identity());
Expand All @@ -2292,7 +2340,7 @@ public void makeHttpRequestsShouldPreserveOnlyDeviceExtAtts() {
.extracting(BidRequest::getDevice)
.extracting(Device::getExt)
.extracting(ExtDevice::getAtts, ExtDevice::getPrebid)
.containsExactly(tuple(1, null));
.containsExactly(tuple(0, null));
}

@Test
Expand Down
Loading