Repository navigation
Conversation
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
Continuous ReleaseCDN linkPublished PackagesCommit hash: 61c1e35 Previous deploymentsThis is an automated message. |
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for making this, it's looking good! One suggestion: we know the name of the hook most of the time, right? Would we be able to make it say like (e.g.) "filterColor requires a value. Make sure to call filterColor.set(value) before filterColor.end()" to be more specific about what the user needs to write?
|
Thanks for the suggestion. I’ve updated all three lifecycle messages to include the hook name and added a finalColor regression test. All 164 tests in p5.Shader.js pass locally. I also need to clarify the AI usage: Claude Code generated this follow up implementation and test changes, with ChatGPT assisting with review. I checked the AI Usage Policy afterward and see that this went beyond the assistive use it asks for. How would you prefer me to handle this revision? |
Resolves #9232
Changes:
set()is called outside a hook'sbegin()/end()block.end()without a value.begin()is called without a matchingend().Testing:
npm test -- test/unit/webgl/p5.Shader.js— 164 passednpm run lint— 0 errors (8 existing warnings)git diff --check— cleanScreenshots of the change:
N/A
AI usage: Used ChatGPT for debugging and review. Claude Code generated the follow up implementation and regression test changes.