Repository navigation
fix: omit OpenMetrics histogram sums for negative buckets - #2643
Merged
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
zeitlinger
force-pushed
the
fix/openmetrics-negative-histogram
branch
from
November 3, 2026 13:45
2082ae6 to
44bb183
Compare
zeitlinger
marked this pull request as ready for review
November 5, 2026 13:15
dhoard
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2631.
In OpenMetrics 1.0, a regular histogram with any negative bucket threshold must not expose a sum. This also requires omitting the paired count while retaining bucket samples. I added regression coverage for a positive sum with zero observations in the negative-threshold bucket, zero and positive threshold controls, and a gauge histogram with a negative sum. The OpenMetrics histogram specification permits negative sums for gauge histograms. Prometheus text 0.0.4 and OpenMetrics 2.0 are unchanged.
mise run lint:fix, the full unit suite, the focused regression tests, and the supplemental full install/build all pass locally;mise run buildreaches Docker-dependent integration tests, which cannot run in this environment because no Docker environment is available.