Skip to content

fix(resume): name row decisions awaiting spec apply [N19] - #19

Closed
bens27 wants to merge 1 commit into
pullboard-dev:mainfrom
bens27:fix/needs-pending-apply
Closed

bens27 wants to merge 1 commit into
pullboard-dev:mainfrom
bens27:fix/needs-pending-apply

Conversation

@bens27

@bens27 bens27 commented Nov 4, 2026

Copy link
Copy Markdown

Gap

When the person approves or declines a row in the local view (port 4891), the decision is recorded on the board but nothing tells the coordinator. personNeeds deliberately excludes rows with a recorded decision (src/needs.js, tested by "approved and declined unapplied rows stay out"), and the relay path's "View request N: Apply the person's recorded row decision" shout only fires for relay/paired-view requests. So on a local board the coordinator's pullboard resume says nothing, the row stays unapplied, and the person sees their approval ignored.

Observed on board superagent, 2026-11-04: G9 approved in the local view; three coordinator resumes later it was still pending apply.

Fix

  • src/resume.js: pendingRowApply, rowDecisionLines and applyFirst, beside commitFirst.
  • src/commands/resume.js: the coordinator card carries pendingApply (id, kind, decision), says The coordinator must apply the person's recorded row decision: G9 approved, pending apply: cd <root> && pullboard spec apply, and next starts with apply the person's recorded row decisions first: ...; then <next>. Inbox stays outermost.
  • personNeeds unchanged.

Test

test/resume-flow.test.js: draft, commit, spec approve G1 without apply, then resume and resume --json name the pending decision and lead with the apply; after spec apply both are quiet. Seen failing before the fix (pendingApply undefined), passing after. node bin/run-tests.js test/resume-flow.test.js test/needs.test.js test/coordinator-resume.test.js: 35/35.

🤖 Generated with Claude Code

The local view records a person's row decision silently, so a coordinator
reading only the needs-the-person section never learns to run spec apply.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@coreyolson coreyolson added the pending Waiting on the next release; we'll come back to it once it ships label Nov 6, 2026
@coreyolson

Copy link
Copy Markdown
Collaborator

This no longer applies: the files it changes moved in the 0.9.4 cell restructure. The gap is still there on main and is filed as item 12276, shipping in 0.9.5. No need to resubmit. Closing. Thanks.

@coreyolson coreyolson closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending Waiting on the next release; we'll come back to it once it ships

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants