Skip to content

fix(gate): skip the wait line for an inherited gate slot [C7] - #22

Closed
bens27 wants to merge 1 commit into
pullboard-dev:mainfrom
bens27:fix/gate-wait-inherited-slot
Closed

bens27 wants to merge 1 commit into
pullboard-dev:mainfrom
bens27:fix/gate-wait-inherited-slot

Conversation

@bens27

@bens27 bens27 commented Nov 6, 2026

Copy link
Copy Markdown

Gap

pullboard submit crashes when an item's frozen check runs pullboard test:

TypeError: Cannot read properties of undefined (reading 'map')
    at src/gate-wait.js:29

Inside submit, the nested pullboard test inherits the gate slot. On that path src/gate.js calls onWait({ admitted: true }) with no holders, and gateWaitReporter calls holders.map on undefined. Since 477b425 ("preserve inherited admission"), any check that calls pullboard test can hit it. On our board one item crashed twice and then submitted on a third try, and another failed every time.

Fix

src/gate-wait.js: an admitted run has no queue to describe, so the reporter returns early. holders also defaults to [].

Test

test/gate-wait-admitted.test.js: reporting { admitted: true } neither throws nor prints. It fails on main with the TypeError above and passes with the fix. After the fix, an item whose check runs pullboard test submitted cleanly.

🤖 Generated with Claude Code

A frozen check that runs pullboard test inside submit inherits the slot and reports admitted with no holders, which crashed submit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coreyolson

coreyolson commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

Thank you. About to ship 0.9.4, a large rewrite that moves everything under src/ into packages/* and apps/*. It was a necessary step for speed, cost and maintainability: this version untangles the codebase, and it sets out how the system grows from here. It also serves as an example for how an existing codebase might migrate legacy code.

Once 0.9.4 ships, we will formalize the contribution process; then we can accept code from outside contributors. Briefly, it's a CLA you agree to with one comment on your pull request. It credits you as the author while keeping Pullboard clean; see CONTRIBUTING.md.

A quick check against 0.9.4:

Once 0.9.4 ships, we'll see where this all stands, for 0.9.5 inclusion.

Hang tight, appreciate your patience.

@coreyolson coreyolson added the pending Waiting on the next release; we'll come back to it once it ships label Nov 6, 2026
@coreyolson

Copy link
Copy Markdown
Collaborator

This no longer applies: the gate was rebuilt in the 0.9.4 cell restructure, and main already skips the wait line for an inherited slot. No need to resubmit. Closing. Thanks.

@coreyolson coreyolson closed this Nov 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pending Waiting on the next release; we'll come back to it once it ships

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants