Repository navigation
Conversation
A frozen check that runs pullboard test inside submit inherits the slot and reports admitted with no holders, which crashed submit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you. About to ship 0.9.4, a large rewrite that moves everything under Once 0.9.4 ships, we will formalize the contribution process; then we can accept code from outside contributors. Briefly, it's a CLA you agree to with one comment on your pull request. It credits you as the author while keeping Pullboard clean; see CONTRIBUTING.md. A quick check against 0.9.4:
Once 0.9.4 ships, we'll see where this all stands, for 0.9.5 inclusion. Hang tight, appreciate your patience. |
|
This no longer applies: the gate was rebuilt in the 0.9.4 cell restructure, and main already skips the wait line for an inherited slot. No need to resubmit. Closing. Thanks. |
Gap
pullboard submitcrashes when an item's frozen check runspullboard test:Inside submit, the nested
pullboard testinherits the gate slot. On that pathsrc/gate.jscallsonWait({ admitted: true })with noholders, andgateWaitReportercallsholders.mapon undefined. Since 477b425 ("preserve inherited admission"), any check that callspullboard testcan hit it. On our board one item crashed twice and then submitted on a third try, and another failed every time.Fix
src/gate-wait.js: an admitted run has no queue to describe, so the reporter returns early.holdersalso defaults to[].Test
test/gate-wait-admitted.test.js: reporting{ admitted: true }neither throws nor prints. It fails on main with the TypeError above and passes with the fix. After the fix, an item whose check runspullboard testsubmitted cleanly.🤖 Generated with Claude Code