Repository navigation
Conversation
The rounding rollover added in python-humanize#329 calls float() on the formatted string, which raises ValueError when the format has text around the number. Skip the rollover check in that case. Fixes python-humanize#366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #366
Changes proposed in this pull request:
naturalsize()rounding rollover at unit boundaries #329 callsfloat()on the formatted string, so a format like"Size: %.1f"raisedValueError. Skip the rollover check when the formatted value isn't a plain number, which restores the 4.15 output for these formats.