Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAC addresses, Finnish business IDs/SSNs, French SSNs, and Indian Aadhaar numbers currently accept a final newline because
$can match before it. For example,mac_address("01:23:45:67:ab:CD\n")returnsTrue.Use full matches for these complete identifier patterns while preserving their existing alphabets and checksum rules. Add a shared 35-case regression covering valid values and trailing LF, CRLF, spaces, and extra text.
Validation: the regression fails in 7 cases on unchanged master; all 1,162 tests and doctests pass after the fix. Ruff lint and formatting, Pyright (0 errors), and Bandit checks pass.