Repository navigation
Validate Base32 quantum lengths and padding - #506
Merged
nandgator merged 1 commit intoOct 22, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base32currently checks only its alphabet, so impossible symbol counts and malformed padding such asA,AAA,AB=andABCDEFGH=validate successfully. These inputs cannot form valid Base32 byte quanta.Validate the final quantum lengths and their corresponding optional padding. Existing unpadded input support remains available. Twelve cases cover malformed input and all five valid final quantum forms, with and without padding.
Validation: seven malformed cases fail before the fix; all 1,125 tests pass. Full Ruff lint and formatting checks pass. Pyright reports nine existing crypto-address diagnostics; the exact same diagnostics reproduce on the unchanged checkout.
The final quantum sizes follow RFC 4648 section 6.