Repository navigation
gh-151633: avoid use-after-free in Counter.update - #151634
Merged
kumaraditya303 merged 15 commits intoNov 9, 2026
Merged
kumaraditya303 merged 15 commits into
kumaraditya303 merged 15 commits into
Conversation
eendebakpt
reviewed
Jun 18, 2026
eendebakpt
reviewed
Jul 7, 2026
Contributor
Author
|
Thanks for the review, I'll take a look ASAP. |
eendebakpt
reviewed
Jul 10, 2026
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
KowalskiThomas
force-pushed
the
kowalski/fix-avoid-use-after-free-in-counter-update
branch
from
July 14, 2026 09:16
192fc9f to
c34c4a2
Compare
Contributor
Author
|
Sorry in advance, I had to rebase on main (instead of merge) because Git wouldn't let me "merge unrelated histories"... Not sure what happened there... |
…use-after-free-in-counter-update
Contributor
Author
|
Just merged |
eendebakpt
reviewed
Oct 27, 2026
eendebakpt
approved these changes
Oct 27, 2026
eendebakpt
left a comment
eendebakpt
left a comment
Contributor
There was a problem hiding this comment.
Thanks @KowalskiThomas. I added one minor change (also to retrigger the CI), but looks good. Performance for large updates is also improved with these changes, which is a nice side effect.
Contributor
Author
|
Thank you @eendebakpt! |
kumaraditya303
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151633.
Counter.updatecan cause a use after free #151633