Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit line continuation currently restores both indentation columns from the expanded column. This causes consistently tab-indented blocks to raise TabError and can also allow ambiguous tab/space indentation that would otherwise be rejected.
Preserve the alternate indentation column separately when recording the first continuation, and restore each column from its own saved value. Keep the existing zero-indentation handling unchanged.
Add regression coverage for tabs, consistent mixed prefixes and spaces, repeated continuations, LF/CRLF, first and subsequent continued statements, and rejection of ambiguous tab/space indentation. The new tests fail with the unpatched lexer and pass with the fix.
Validation: Windows x64 CPython 3.16 debug build; test_syntax, test_tokenize, test_grammar and test_ast pass (575 tests, 2 skipped). Ruff and git diff --check pass.