Skip to content

gh-156026: Add warning about link targets to tarfile.tar_filter #159019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
encukou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-156026: Add warning about link targets to tarfile.tar_filter #159019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Doc/library/tarfile.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1124,6 +1124,13 @@ reused in custom filters:

Return the modified ``TarInfo`` member.

.. warning::

This filter does not check link targets (:attr:`TarInfo.linkname`).
It allows benign cases (like links to ``/dev/null``), but it also allows
links (symbolic and hard) to arbitrary files on the filesystem,
potentially granting unintended access to these files.

.. versionchanged:: next

Filenames containing ``..`` components are now normalized.
Expand Down
Loading