Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
csv.Sniffer.sniff()can select the wrong quote character because the first of two equally scoring candidates wins, regardless of how often each quote character starts a field.To fix this bug, the sniffer now compares how many fields begin with each quote character when candidates have the same score, delimiter, and escape character. It counts only records included in each candidate's trial parse and skips quoted field contents; the count is computed only when needed to resolve a tie. If the counts are equal, the existing candidate order is preserved.
The regression tests cover both quote-character directions, mixed quote characters, and quoted-looking field data. All 157
test_csvtests pass.Fixes gh-159635