Repository navigation
gh-157210: Attach a combining mark in the last curses Textbox cell - #159651
Merged
serhiy-storchaka merged 1 commit intoOct 22, 2026
Merged
Conversation
A combining character typed into the lower-right cell of a Textbox no longer takes a cell of its own, pushing its base character off the window edge. In insert mode it no longer shifts the following text. Co-authored-by: Vyron Vasileiadis <hi@fedonman.com> Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A combining character typed into the lower-right cell of a
Textbox, which is written withinsch(), took a cell of its own and pushed its base character off the window edge. It is now merged into the character typed into that cell, or attached to the preceding character if the cursor was moved there, asaddch()does elsewhere. Zero-width characters with a canonical combining class of 0 are included. A mark that does not fit in the cell is dropped.In insert mode, a combining character no longer shifts the following text right.
Based on #157211.
Textbox's last cell loses the base character #157210🤖 Generated with Claude Code