Repository navigation
gh-160307: Complete final multibyte incremental decoding - #160629
Open
kinqsradio wants to merge 1 commit into
Open
kinqsradio wants to merge 1 commit into
kinqsradio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160307.
Final incremental decoding could return with input still buffered when an error handler consumed only part of an incomplete sequence. For example, decoding
b'\x8f\x00'as EUC-JP withsurrogateescapeandfinal=Truereturned'\udc8f'instead of'\udc8f\x00'. The same issue affected EUC-JIS variants and GB18030, including reads throughTextIOWrapper.Resume ordinary decoding after each final error-handler call, repeating final error handling if another incomplete fragment remains. Add regression coverage for chunk boundaries, partial custom error handlers, exception recovery, and file reads, plus a NEWS entry.
Validation on a macOS ARM64 debug build:
./python.exe -m test test_multibytecodec -R 3:3passes with no leaks in measured repetitions.surrogateescape, plus deterministic longer inputs with four error handlers.make patchcheckandgit diff --checkpass.AI assistance was used to investigate the issue, prepare the patch and tests, and run local validation.
euc_jpandgb18030incremental decoders drop input after an incomplete trailing sequence undersurrogateescape#160307