Repository navigation
gh-161094: Fix zipfile.is_zipfile() raising ValueError on file-like objects - #161095
Merged
Merged
Conversation
…ects Return False instead of seeking to a negative offset when the end of central directory record places the central directory before the start of the file.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 17:51
gpshead
enabled auto-merge (squash)
November 1, 2026 17:52
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161120 is a backport of this pull request to the 3.15 branch. |
|
GH-161121 is a backport of this pull request to the 3.14 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip the central directory check in
zipfile.is_zipfile()when the computed start of the central directory is negative, mirroring the "Bad offset for central directory" check inZipFile. Previously the seek raisedValueErrorfor in-memory file objects such asio.BytesIO, whichis_zipfile()does not catch, while real files raised a caughtOSError. The disk-number check is left alone; gh-155814 deals with that separately.Fixes #161094
zipfile.is_zipfile()raisesValueErrorfor file-like objects with a negative central directory offset #161094