Repository navigation
gh-161096: Reject invalid TZif abbreviation block sizes in zoneinfo - #161097
Merged
Merged
Conversation
…info ZoneInfo.from_file() now raises ValueError for a negative charcnt or one above 512, and reads the abbreviation index as unsigned.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 17:55
gpshead
enabled auto-merge (squash)
November 1, 2026 17:56
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161122 is a backport of this pull request to the 3.15 branch. |
|
GH-161123 is a backport of this pull request to the 3.14 branch. |
gpshead
added a commit
that referenced
this pull request
Nov 1, 2026
gpshead
added a commit
that referenced
this pull request
Nov 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
load_data()now rejects acharcntoutside 0..512 withValueErrorbefore reading the abbreviation block, next to the existing invalid transition index check from gh-145883. Abbreviation indexes are one octet, so a longer block cannot be addressed and only multiplies the per-index copies; tzcode'sziclimits it to 50 bytes. The local time type'sabbrindis also unpacked as unsigned so that indexes 128..255 resolve to the right abbreviation. BothZoneInfoimplementations parse through_common.load_data(), so no C change is needed.Fixes #161096
ANT-2026-W7U7UDLT
ZoneInfo.from_file()accepts any TZifcharcntand can use 512x the file size in memory #161096