Repository navigation
gh-161098: Unlink the new ShareableList block if packing a value fails - #161099
Merged
Merged
Conversation
…e fails ShareableList(sequence) created its shared memory block before packing the values, so an unpackable value (an int outside int64, a lone surrogate) left the block behind with no way for the caller to release it.
gpshead
added
needs backport to 3.14
gpshead
marked this pull request as ready for review
November 1, 2026 18:03
gpshead
enabled auto-merge (squash)
November 1, 2026 18:04
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161131 is a backport of this pull request to the 3.14 branch. |
|
GH-161132 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If packing the values fails in
ShareableList.__init__, close and unlink the shared memory block it just created before re-raising. This branch is only reached when a sequence is given, so the block was always created by this call and nothing else holds a reference to it;unlink()also unregisters it from the resource tracker. This also coversSharedMemoryManager.ShareableList(), which goes through the same constructor.Fixes #161098
ANT-2026-740NDRCA
ShareableListleaves its shared memory block behind when packing fails #161098