Repository navigation
gh-161110: Make minidom getElementById() stable for duplicate IDs - #161111
Merged
Merged
Conversation
Visit child nodes in document order and keep the first cached element for each ID, so the first element in document order is returned.
gpshead
marked this pull request as ready for review
November 1, 2026 18:37
gpshead
enabled auto-merge (squash)
November 1, 2026 18:37
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document.getElementById()now visits child nodes in document order and only caches the first element seen for each ID, so for duplicate IDs it returns the first element in document order and keeps returning it until the document is modified. This matches the WHATWG DOM and libxml2. Documents with unique IDs are unaffected; for documents with duplicate IDs the returned element changes, so this is not meant for backport.Fixes #161110
ANT-2026-C52DMQ8Z
xml.dom.minidom.Document.getElementById()result for duplicate IDs depends on earlier lookups #161110