Skip to content

gh-131178: Fix test_cli_retrieve_file when stdout is StringIO in test_ftplib #161135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
orsenthil merged 3 commits into from
Nov 2, 2026
Merged

gh-131178: Fix test_cli_retrieve_file when stdout is StringIO in test_ftplib #161135

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ea3a1
gh-131178: Mock sys.stdout in test_ftplib CLI retrieve test
rudy-07 Nov 1, 2026
efc9fb7
Fix the refleaks by not creating an instance of OSError
orsenthil Nov 2, 2026
d2a6f96
Merge branch 'main' into fix-ftplib-cli-stdout
orsenthil Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Lib/test/test_ftplib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1242,15 +1242,18 @@ def test_cli_commands(self, mock_netrc, mock_ftp_cls):
@mock.patch('netrc.netrc', side_effect=OSError)
def test_cli_retrieve_file(self, mock_netrc, mock_ftp_cls):
mock_ftp = mock_ftp_cls.return_value
with mock.patch('sys.argv', ['ftplib', 'example.com', 'testfile.txt']):
with mock.patch('sys.argv', ['ftplib', 'example.com', 'testfile.txt']), \
mock.patch('sys.stdout') as mock_stdout:
ftplib.test()
mock_ftp.retrbinary.assert_called_once()
args, kwargs = mock_ftp.retrbinary.call_args
self.assertEqual(args[0], 'RETR testfile.txt')
mock_ftp.retrbinary.assert_called_once_with(
'RETR testfile.txt', mock_stdout.buffer.write, 1024
)
mock_stdout.buffer.flush.assert_called_once()
mock_stdout.flush.assert_called_once()
mock_ftp.quit.assert_called_once()

@mock.patch('ftplib.FTP')
@mock.patch('netrc.netrc', side_effect=OSError('file not found'))
@mock.patch('netrc.netrc', side_effect=OSError)
def test_cli_custom_rcfile_error(self, mock_netrc, mock_ftp_cls):
with mock.patch('sys.argv', ['ftplib', '-rnonexistent.netrc', 'example.com']), \
support.captured_stderr() as stderr:
Expand Down
Loading