Skip to content

gh-161229: Accept None for globals and locals in __lazy_import__() - #161231

Open
lazerg wants to merge 2 commits into
python:mainfrom
lazerg:fix-issue-161229
Open

gh-161229: Accept None for globals and locals in __lazy_import__()#161231
lazerg wants to merge 2 commits into
python:mainfrom
lazerg:fix-issue-161229

Conversation

@lazerg

@lazerg lazerg commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

__lazy_import__() shows globals=None and locals=None in its signature, but passing globals=None explicitly raised TypeError because only the C-level NULL default fell back to the caller's globals. This treats None the same as an omitted argument.

@bedevere-app bedevere-app Bot mentioned this pull request Nov 3, 2026
Open
sobolevn
sobolevn approved these changes Nov 3, 2026
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@Yhg1s Yhg1s Awaiting requested review from Yhg1s Yhg1s is a code owner
@DinoV DinoV Awaiting requested review from DinoV DinoV is a code owner
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lazerg @sobolevn