Repository navigation
Conversation
|
All commit authors signed the Contributor License Agreement. |
raman118
force-pushed
the
gh-161081-copydata-shape
branch
from
November 12, 2026 21:29
affb1fe to
f141e72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-161081.
PyObject_CopyData()used source-buffer indices for both buffers on its non-contiguous copy path. When their shapes differed, this could write to incorrect offsets or read beyond the source index array. Validate that non-contiguous source and destination buffers have the same dimensions and shape before copying.Add a regression test using
_testbufferarrays with different shapes. The test failed before this change because the copy returned success; it now raisesBufferError.Tests:
PCbuild\\build.bat -d -p x64 -M -qPCbuild\\amd64\\python_d.exe -m test -v -m test_mismatched_shape test_bufferPCbuild\\amd64\\python_d.exe -m test -v test_buffer(98 passed, 2 skipped)PCbuild\\amd64\\python_d.exe Tools\\patchcheck\\patchcheck.pyAI assistance was used to investigate the issue and prepare this change. I reviewed the code and test behavior, including the failing pre-fix regression, before opening this PR.