Skip to content

gh-161625: Fix compiler warnings in _remote_debugging - #161626

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:fix_remote_debugging_warnings
Nov 8, 2026
Merged

gh-161625: Fix compiler warnings in _remote_debugging#161626
vstinner merged 3 commits into
python:mainfrom
vstinner:fix_remote_debugging_warnings

Conversation

@vstinner

@vstinner vstinner commented Nov 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

Fix compiler warnings when Python is built in 32-bit mode on Windows.

@vstinner
pythongh-161625: Fix compiler warnings in _remote_debugging
f1f89f7 
Fix compiler warnings when Python is built in 32-bit mode on Windows.
@vstinner
vstinner requested a review from pablogsal as a code owner November 8, 2026 16:45
@bedevere-app bedevere-app Bot mentioned this pull request Nov 8, 2026
Closed
@vstinner vstinner added the needs backport to 3.15 bugs and security fixes label Nov 8, 2026
@vstinner vstinner mentioned this pull request Nov 8, 2026
Merged
@vstinner

vstinner commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

Oh, there is one remaining warning:

D:\a\cpython\cpython\Modules\_remote_debugging\binary_io_reader.c(919,31): warning C4244: '=': conversion from 'uint64_t' to 'size_t', possible loss of data [D:\a\cpython\cpython\PCbuild\_remote_debugging.vcxproj]

I pushed a change to fix it.

The _uuid warning is fixed by: #161628

D:\a\cpython\cpython\Modules\_uuidmodule.c(302,50): warning C4244: 'initializing': conversion from 'uint64_t' to 'Py_ssize_t', possible loss of data [D:\a\cpython\cpython\PCbuild\_uuid.vcxproj]

@vstinner

vstinner commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

There are no more warnings on "Windows / Build and test (Win32, switch-case)" CI: 0 Warning(s) says "Build CPython".

@vstinner
vstinner enabled auto-merge (squash) November 8, 2026 18:54
@vstinner
vstinner merged commit dcf9087 into python:main Nov 8, 2026
96 of 98 checks passed
@vstinner
vstinner deleted the fix_remote_debugging_warnings branch November 8, 2026 19:04
@miss-islington-app

miss-islington-app Bot commented Nov 8, 2026

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-app

bedevere-app Bot commented Nov 8, 2026

Copy link
Copy Markdown

GH-161638 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 8, 2026
vstinner added a commit that referenced this pull request Nov 8, 2026
@miss-islington @vstinner
[3.15] gh-161625: Fix compiler warnings in _remote_debugging (GH-161626…
59ef77b 
…) (#161638)

gh-161625: Fix compiler warnings in _remote_debugging (GH-161626)

Fix compiler warnings when Python is built in 32-bit mode on Windows.
(cherry picked from commit dcf9087)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vstinner