Skip to content

gh-111178: Set function=False by default in support.check_sanitizer() - #161640

Merged
vstinner merged 1 commit into
python:mainfrom
vstinner:sanitize_function
Nov 9, 2026
Merged

vstinner merged 1 commit into
python:mainfrom
vstinner:sanitize_function

Conversation

@vstinner

@vstinner vstinner commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Update also libregrtest.utils to detect function sanitizer (-fsanitize=function).

…izer()

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).
@vstinner

vstinner commented Nov 8, 2026

Copy link
Copy Markdown
Member Author

The function parameter was added to check_sanitizer() by commit 643dd51. I made the change, but I don't remember why it's function=True by default. IMO it's a mistake and it should be function=False by default, as other parameters.

See also #111178.

@vstinner
vstinner merged commit 4e10d4f into python:main Nov 9, 2026
108 of 110 checks passed
@vstinner
vstinner deleted the sanitize_function branch November 9, 2026 23:25
@miss-islington-app

Copy link
Copy Markdown

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 4e10d4fef5c073faaaf04ce5e03749a5dbe7716b 3.15

@miss-islington-app

Copy link
Copy Markdown

Sorry, @vstinner, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 4e10d4fef5c073faaaf04ce5e03749a5dbe7716b 3.14

vstinner added a commit to vstinner/cpython that referenced this pull request Nov 9, 2026
…izer() (python#161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).

(cherry picked from commit 4e10d4f)
@bedevere-app

bedevere-app Bot commented Nov 9, 2026

Copy link
Copy Markdown

GH-161713 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 9, 2026
@vstinner vstinner removed the needs backport to 3.14 bugs and security fixes label Nov 9, 2026
vstinner added a commit that referenced this pull request Nov 10, 2026
…tizer() (#161640) (#161713)

gh-111178: Set function=False by default in support.check_sanitizer() (#161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).

(cherry picked from commit 4e10d4f)
vstinner added a commit that referenced this pull request Nov 10, 2026
…tizer() (GH-161640) (GH-161713) (#161720)

[3.15] gh-111178: Set function=False by default in support.check_sanitizer() (GH-161640) (GH-161713)

gh-111178: Set function=False by default in support.check_sanitizer() (GH-161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).
(cherry picked from commit 39d10e3)


(cherry picked from commit 4e10d4f)

Co-authored-by: Victor Stinner <vstinner@python.org>
orsenthil pushed a commit to orsenthil/cpython that referenced this pull request Nov 12, 2026
…izer() (python#161640)

Update also libregrtest.utils to detect function sanitizer
(-fsanitize=function).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant