Repository navigation
[3.15] gh-159452: Run the regen-configure container as the invoking user (GH-159454) - #161680
Merged
Merged
Conversation
…er (pythonGH-159454) `Tools/build/regen-configure.sh` ran the Autoconf container as root, so with a rootful Docker daemon the regenerated files and `autom4te.cache` ended up owned by root. The stale cache broke subsequent runs and couldn't be removed without sudo. Run the container as the invoking user instead: `--userns=keep-id` for Podman, `-u UID:GID` for rootful Docker. Rootless runtimes already map container root to the invoking user and need nothing. Also remove `autom4te.cache` before and after the run, using the same image, so an existing root-owned cache gets cleaned up too. (cherry picked from commit 7b1bc41) Co-authored-by: Sendao Yan <yansendao@126.com>
itamaro
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools/build/regen-configure.shran the Autoconf container as root, sowith a rootful Docker daemon the regenerated files and
autom4te.cacheended up owned by root. The stale cache broke subsequent runs and
couldn't be removed without sudo.
Run the container as the invoking user instead:
--userns=keep-idforPodman,
-u UID:GIDfor rootful Docker. Rootless runtimes already mapcontainer root to the invoking user and need nothing. Also remove
autom4te.cachebefore and after the run, using the same image, so anexisting root-owned cache gets cleaned up too.
(cherry picked from commit 7b1bc41)
Co-authored-by: Sendao Yan yansendao@126.com