Repository navigation
gh-161973: Fix SequenceMatcher.get_grouped_opcodes() mutating the cached opcodes - #161985
Open
tanveer-arch wants to merge 2 commits into
Open
tanveer-arch wants to merge 2 commits into
tanveer-arch wants to merge 2 commits into
Conversation
…he cached opcodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #161973.
SequenceMatcher.get_opcodes()caches its result and returns the same list object on every call.get_grouped_opcodes()took that list and overwrote its first and last entries while trimming context, so after one call the cached opcodes no longer covered the whole input and a laterget_opcodes()— or a widern— returned the trimmed list.Fix: copy the list in
get_grouped_opcodes()before trimming, so the cached opcodes are never mutated. Adds a regression test that consumesget_grouped_opcodes(1)and assertsget_opcodes()still returns the full list, and that a laterget_grouped_opcodes(3)matches a fresh matcher.AI assistance disclosure: I used an AI tool to help investigate and draft this fix; I reviewed the change and the test in detail and verified them by building CPython from main and running the difflib test suite.