Repository navigation
Tighten the AI guidelines and rules for new contributors #1956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
picnixz
wants to merge
1
commit into
python:main
Choose a base branch
from
picnixz:ai-policy-new-contributors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+46
−5
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't these rules apply to all contributors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to allow "regular" contributors use of AI because of the trust they built, even if they are neither triagers nor core devs. But I don't want that the first contributions of users is solely AI. But if you want a stronger policy where this applies to everyone, I'm fine as well, though I think it's sad that core devs can't use what the AI generated for them.
It's hard to convene that but informally:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that llm-based contributions are annoying, and I agree that we need a way to trust the new contributos and for the new contributors to earn our trust.
But I disagree with this particular approach of creating yet another class of contributors: those who are allowed to use AI and those who are not.
I've been asking myself what I want to know from contributors when they use AI. I still don't have answers or solutions, but these are the things I've been thinking about:I want to know what is their contribution to the PR, did they simply point the agent to the issue and click accept? Did they ask the agent first to explain and clarify? Did they try to verify, replicate, weigh the options from the agents. Did they make any judgement calls, was there a time that they went against the agents recommendations, if so what was that? These are the things that would help me gain trust in the contributor, not the number of PRs they've made and not their status or core dev or not. (I've shared a long form reflection on my personal blog)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples and additional text in the first two sections make sense. Thanks for taking the time to add additional detail.
I wasn't clear earlier that my question was in the "Additional rules for new contributors" section. I do want PRs from the core team, triagers, and contributors to be used responsibly. I don't think that we should have a different process for first-time contributors. To me, it feels elitist and creates an additional barrier for contributors.
I believe that it would be most effective to guide the first-time contributor (or their AI tool) to create a well-scoped PR. Basically, helping the AI tool follow a template for a valuable contribution:
For the human, strengthening the wording to respect maintainers' time and "demonstrating commitment to the project".
"Demonstrating commitment to the project" could encourage most of what you suggested.