Skip to content

Remove unnecessary 3.13 macOS installer code #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove unnecessary 3.13 macOS installer code #466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aecfd8c
Remove unnecessary 3.13 macOS installer code
hugovk Oct 26, 2026
7fd4fe4
Simplify regex, files now named like python-3.14.0-macos11.pkg not py…
hugovk Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,6 @@ def run_cmd(
}


def macos_description(version: tuple[int, int, int]) -> str:
if version >= (3, 14):
return "for macOS 10.15 and later"
else:
return "for macOS 10.13 and later"


def winarm64_experimental(version: tuple[int, int, int]) -> str:
if version >= (3, 15):
return ""
Expand Down Expand Up @@ -157,12 +150,12 @@ def get_file_descriptions(
),
(rx(r"\.exe$"), ("Windows installer (32-bit)", "windows", False, "")),
(
rx(r"-macos(x)?1[1-9](\.[0-9]*)?\.pkg$"),
rx(r"-macos1[1-9]\.pkg$"),
(
"macOS installer",
"macos",
True,
macos_description(v),
"for macOS 10.15 and later",
),
),
(
Expand Down
11 changes: 0 additions & 11 deletions tests/test_add_to_pydotorg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,17 +179,6 @@ def test_minor_version(release: str, expected: str) -> None:
assert add_to_pydotorg.minor_version(release) == expected


@pytest.mark.parametrize(
["release", "expected"],
[
((3, 13, 0), "for macOS 10.13 and later"),
((3, 14, 0), "for macOS 10.15 and later"),
],
)
def test_macos_description(release: tuple[int, int, int], expected: str) -> None:
assert add_to_pydotorg.macos_description(release) == expected


def test_list_files(fs: FakeFilesystem) -> None:
# Arrange
fake_ftp_root = "/fake_ftp_root"
Expand Down
Loading