Repository navigation
[google-cloud-ndb] Add set_if_not_exists to global caches - #16568
Merged
srittau merged 2 commits intoOct 20, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Oct 20, 2026
| @abc.abstractmethod | ||
| def set(self, items, expires=None): ... | ||
| @abc.abstractmethod | ||
| def set_if_not_exists(self, items: Mapping[bytes, bytes | None], expires: float | None = None) -> dict[bytes, bool]: ... |
Collaborator
There was a problem hiding this comment.
Mapping should be avoided, since it's not a protocol, but a weird ABC. This could use SupportsItems (from _typeshed).
Contributor
Author
There was a problem hiding this comment.
Done, it now uses SupportsItems[bytes, bytes | None]. All four implementations only call items.items().
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlobalCache.set_if_not_existsis an abstract method at runtime, but it was missing from the stub, so type checkers did not flag customGlobalCachesubclasses that forget to implement it (instantiating one fails withTypeErrorat runtime).This adds the abstract method and the implementations on
RedisCache,MemcacheCacheand_InProcessGlobalCache, typed from the docstring: a mapping of keys to serialized entities in, adictof key to "was set" flags out.Upstream (v2.4.0, unchanged in 2.4.2): https://github.com/googleapis/python-ndb/blob/v2.4.0/google/cloud/ndb/global_cache.py#L117-L132
AI agent used: Claude Code (claude-opus-5-5).