Skip to content

Arm backend: Prepare TOSA validation and lowering for int64 #24128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingo merged 7 commits into from
Oct 29, 2026
+253 −23
Merged

Arm backend: Prepare TOSA validation and lowering for int64 #24128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26d6bb9
Arm backend: Add a spec predicate for keeping int64
abm-77 Oct 27, 2026
70306cc
Arm backend: Let the TOSA spec decide whether int64 reaches serializa…
abm-77 Oct 27, 2026
4142ea9
Arm backend: Accept int64 in the dialect validators EXT-INT64 covers
abm-77 Oct 27, 2026
faf53cc
Arm backend: Declare int64 on the node visitors EXT-INT64 covers
abm-77 Oct 27, 2026
e5e75fc
Arm backend: Test int64 in the dialect validators EXT-INT64 covers
abm-77 Oct 27, 2026
3ca3793
Arm backend: Address review on int64 visitor and dialect declarations
abm-77 Oct 28, 2026
160c2b2
Merge branch 'main' into arm-int64-spec-aware
YufengShi-dudu Oct 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backends/arm/operators/op_flip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ def define_node(
supported_dtypes.append(ts.DType.FP8E4M3)
if self.tosa_spec.support_extension("fp8e5m2"):
supported_dtypes.append(ts.DType.FP8E5M2)
if self.tosa_spec.support_extension("int64"):
Comment thread
abm-77 marked this conversation as resolved.
supported_dtypes.append(ts.DType.INT64)

validate_num_inputs(self.target, inputs, 2)
validate_same_dtype(self.target, [inputs[0], output])
Expand Down
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_abs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,11 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
tosa_op=ts.Op.ABS,
attr_method="AbsAttribute",
num_inputs=1,
input_dtypes=[ts.DType.INT32, ts.DType.FP16, ts.DType.FP32, ts.DType.BF16],
input_dtypes=[
ts.DType.INT32,
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
],
)
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_add.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,11 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
tosa_op=ts.Op.ADD,
attr_method="AddAttribute",
num_inputs=2,
input_dtypes=[ts.DType.INT32, ts.DType.FP16, ts.DType.FP32, ts.DType.BF16],
input_dtypes=[
ts.DType.INT32,
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
],
)
6 changes: 3 additions & 3 deletions backends/arm/operators/op_tosa_binary_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
"tosa.BITWISE_AND.default",
ts.Op.BITWISE_AND,
"BitwiseAndAttribute",
[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32],
[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32, ts.DType.INT64],
)
binary_operator_factory(
"tosa.BITWISE_OR.default",
ts.Op.BITWISE_OR,
"BitwiseOrAttribute",
[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32],
[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32, ts.DType.INT64],
)
binary_operator_factory(
"tosa.BITWISE_XOR.default",
ts.Op.BITWISE_XOR,
"BitwiseXorAttribute",
[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32],
[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32, ts.DType.INT64],
)
binary_operator_factory(
"tosa.INTDIV.default",
Expand Down
7 changes: 6 additions & 1 deletion backends/arm/operators/op_tosa_bitwise_not.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,10 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
tosa_op=ts.Op.BITWISE_NOT,
attr_method="BitwiseNotAttribute",
num_inputs=1,
input_dtypes=[ts.DType.INT8, ts.DType.INT16, ts.DType.INT32],
input_dtypes=[
ts.DType.INT8,
ts.DType.INT16,
ts.DType.INT32,
ts.DType.INT64,
],
)
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_eq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,13 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
tosa_op=ts.Op.EQUAL,
attr_method="EqualAttribute",
num_inputs=2,
input_dtypes=[ts.DType.INT32, ts.DType.FP16, ts.DType.FP32, ts.DType.BF16],
input_dtypes=[
ts.DType.INT32,
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
],
output_dtypes=[ts.DType.BOOL],
same_dtype_with_output=False,
dtype_check_inputs_only=True,
Expand Down
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_ge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@
SimpleNodeVisitorConfig,
)

COMPARE_INPUT_DTYPES = [ts.DType.INT32, ts.DType.FP32, ts.DType.BF16, ts.DType.FP16]
COMPARE_INPUT_DTYPES = [
ts.DType.INT32,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.FP16,
ts.DType.INT64,
]


@register_node_visitor
Expand Down
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_gt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,13 @@
SimpleNodeVisitorConfig,
)

COMPARE_INPUT_DTYPES = [ts.DType.INT32, ts.DType.FP32, ts.DType.BF16, ts.DType.FP16]
COMPARE_INPUT_DTYPES = [
ts.DType.INT32,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.FP16,
ts.DType.INT64,
]


@register_node_visitor
Expand Down
1 change: 1 addition & 0 deletions backends/arm/operators/op_tosa_identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
ts.DType.FP8E4M3,
ts.DType.FP8E5M2,
],
Expand Down
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_maximum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,11 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
attr_method="MaximumAttribute",
attr_kwargs={"nan_mode": ts.NanPropagationMode.PROPAGATE},
num_inputs=2,
input_dtypes=[ts.DType.INT32, ts.DType.FP16, ts.DType.FP32, ts.DType.BF16],
input_dtypes=[
ts.DType.INT32,
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
],
)
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_minimum.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,11 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
attr_method="MinimumAttribute",
attr_kwargs={"nan_mode": ts.NanPropagationMode.PROPAGATE},
num_inputs=2,
input_dtypes=[ts.DType.INT32, ts.DType.FP16, ts.DType.FP32, ts.DType.BF16],
input_dtypes=[
ts.DType.INT32,
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
],
)
1 change: 1 addition & 0 deletions backends/arm/operators/op_tosa_mul.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def define_node(
ts.DType.INT32,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
ts.DType.FP16,
],
)
Expand Down
2 changes: 2 additions & 0 deletions backends/arm/operators/op_tosa_neg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ def define_node(
ts.DType.BF16,
ts.DType.FP32,
]
if self.tosa_spec.support_extension("int64"):
Comment thread
abm-77 marked this conversation as resolved.
supported_dtypes.append(ts.DType.INT64)

validate_num_inputs(self.target, inputs, 1)
validate_same_dtype(self.target, [*inputs, output])
Expand Down
8 changes: 7 additions & 1 deletion backends/arm/operators/op_tosa_sub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,11 @@ def get_config(cls) -> SimpleNodeVisitorConfig:
tosa_op=ts.Op.SUB,
attr_method="SubAttribute",
num_inputs=2,
input_dtypes=[ts.DType.INT32, ts.DType.FP16, ts.DType.FP32, ts.DType.BF16],
input_dtypes=[
ts.DType.INT32,
ts.DType.FP16,
ts.DType.FP32,
ts.DType.BF16,
ts.DType.INT64,
],
)
2 changes: 2 additions & 0 deletions backends/arm/operators/op_where.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ def define_node(
]
if self.tosa_spec.support_float():
supported_dtypes += [ts.DType.FP16, ts.DType.FP32, ts.DType.BF16]
if self.tosa_spec.support_extension("int64"):
supported_dtypes.append(ts.DType.INT64)

validate_num_inputs(self.target, inputs, 3)
# Not first input, which is condition tensor.
Expand Down
14 changes: 8 additions & 6 deletions backends/arm/operators/operator_validation_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,14 @@ def supported_data_layout_dtypes(
supported_dtypes.append(ts.DType.INT16)
if tosa_spec.support_float():
supported_dtypes.extend([ts.DType.FP16, ts.DType.FP32])
if tosa_spec.support_extension("bf16"):
supported_dtypes.append(ts.DType.BF16)
if tosa_spec.support_extension("fp8e4m3"):
supported_dtypes.append(ts.DType.FP8E4M3)
if tosa_spec.support_extension("fp8e5m2"):
supported_dtypes.append(ts.DType.FP8E5M2)
for extension, dtype in (
("int64", ts.DType.INT64),
("bf16", ts.DType.BF16),
("fp8e4m3", ts.DType.FP8E4M3),
("fp8e5m2", ts.DType.FP8E5M2),
):
if tosa_spec.support_extension(extension):
supported_dtypes.append(dtype)
if include_mxfp and tosa_spec.support_extension("mxfp"):
for dtype in (ts.DType.FP8E4M3, ts.DType.FP8E5M2):
if dtype not in supported_dtypes:
Expand Down
38 changes: 38 additions & 0 deletions backends/arm/test/misc/tosa_dialect/test_tosa_dialect_binary_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,3 +385,41 @@ def test_extrema_ops_reject_int32_on_fp_profile(op_name: str) -> None:
getattr(exir_ops.backend.tosa, op_name).default(
*_to_fake(mode, input1, input2)
)


_INT64_BINARY_OPS = [
"ADD",
"SUB",
"MUL",
"MAXIMUM",
"MINIMUM",
"BITWISE_OR",
"BITWISE_XOR",
]


@pytest.mark.parametrize("op_name", _INT64_BINARY_OPS)
@pytest.mark.parametrize(
("spec", "accepted"), [("TOSA-1.1+INT+int64", True), ("TOSA-1.1+INT", False)]
)
def test_binary_ops_take_int64_only_with_the_extension(
op_name: str, spec: str, accepted: bool
) -> None:
input1 = torch.randint(1, 16, (2, 1, 3), dtype=torch.int64)
input2 = torch.randint(1, 8, (1, 4, 3), dtype=torch.int64)

with TosaLoweringContext(
TosaSpecification.create_from_string(spec)
), FakeTensorMode() as mode:
if not accepted:
with pytest.raises(TosaValueError):
getattr(exir_ops.backend.tosa, op_name).default(
*_to_fake(mode, input1, input2)
)
return
output = getattr(exir_ops.backend.tosa, op_name).default(
*_to_fake(mode, input1, input2)
)

assert output.dtype == torch.int64
assert tuple(output.shape) == (2, 4, 3)
27 changes: 27 additions & 0 deletions backends/arm/test/misc/tosa_dialect/test_tosa_dialect_comparison.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,30 @@ def test_compare_ops_reject_int32_on_fp_profile(op_name: str) -> None:
getattr(exir_ops.backend.tosa, op_name).default(
*_to_fake(mode, input1, input2)
)


@pytest.mark.parametrize("op_name", ["EQUAL", "GREATER", "GREATER_EQUAL"])
@pytest.mark.parametrize(
("spec", "accepted"), [("TOSA-1.1+INT+int64", True), ("TOSA-1.1+INT", False)]
)
def test_compare_ops_take_int64_only_with_the_extension(
op_name: str, spec: str, accepted: bool
) -> None:
input1 = torch.randint(1, 16, (2, 1, 3), dtype=torch.int64)
input2 = torch.randint(1, 8, (1, 4, 3), dtype=torch.int64)

with TosaLoweringContext(
TosaSpecification.create_from_string(spec)
), FakeTensorMode() as mode:
if not accepted:
with pytest.raises(TosaValueError):
getattr(exir_ops.backend.tosa, op_name).default(
*_to_fake(mode, input1, input2)
)
return
output = getattr(exir_ops.backend.tosa, op_name).default(
*_to_fake(mode, input1, input2)
)

assert output.dtype == torch.bool
assert tuple(output.shape) == (2, 4, 3)
25 changes: 25 additions & 0 deletions backends/arm/test/misc/tosa_dialect/test_tosa_dialect_ternary_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,3 +147,28 @@ def test_tosa_select_rejects_bfloat16_without_bf16_extension() -> None:
exir_ops.backend.tosa.SELECT.default(
*_to_fake(mode, condition, input1, input2)
)


@pytest.mark.parametrize(
("spec", "accepted"), [("TOSA-1.1+INT+int64", True), ("TOSA-1.1+INT", False)]
)
def test_select_takes_int64_only_with_the_extension(spec: str, accepted: bool) -> None:
condition = torch.randint(0, 2, (2, 1, 3), dtype=torch.bool)
input1 = torch.randint(-8, 8, (1, 4, 3), dtype=torch.int64)
input2 = torch.randint(-8, 8, (1, 4, 3), dtype=torch.int64)

with TosaLoweringContext(
TosaSpecification.create_from_string(spec)
), FakeTensorMode() as mode:
if not accepted:
with pytest.raises(TosaValueError):
exir_ops.backend.tosa.SELECT.default(
*_to_fake(mode, condition, input1, input2)
)
return
output = exir_ops.backend.tosa.SELECT.default(
*_to_fake(mode, condition, input1, input2)
)

assert output.dtype == torch.int64
assert tuple(output.shape) == (2, 4, 3)
26 changes: 26 additions & 0 deletions backends/arm/test/misc/tosa_dialect/test_tosa_dialect_unary_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,3 +392,29 @@ def test_logical_not_rejects_non_bool() -> None:
), FakeTensorMode() as mode:
with pytest.raises(TosaValueError, match="requires bool inputs"):
exir_ops.backend.tosa.LOGICAL_NOT.default(mode.from_tensor(sample_input))


@pytest.mark.parametrize("op_name", ["ABS", "NEGATE", "BITWISE_NOT"])
@pytest.mark.parametrize(
("spec", "accepted"), [("TOSA-1.1+INT+int64", True), ("TOSA-1.1+INT", False)]
)
def test_unary_ops_take_int64_only_with_the_extension(
op_name: str, spec: str, accepted: bool
) -> None:
input_tensor = torch.randint(1, 16, (2, 3), dtype=torch.int64)

with TosaLoweringContext(
TosaSpecification.create_from_string(spec)
), FakeTensorMode() as mode:
if not accepted:
with pytest.raises(TosaValueError):
getattr(exir_ops.backend.tosa, op_name).default(
mode.from_tensor(input_tensor)
)
return
output = getattr(exir_ops.backend.tosa, op_name).default(
mode.from_tensor(input_tensor)
)

assert output.dtype == torch.int64
assert tuple(output.shape) == (2, 3)
9 changes: 9 additions & 0 deletions backends/arm/tosa/dialect/ops/_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@
_VALID_NAN_MODES = {"PROPAGATE", "IGNORE"}


def validate_int64_support(op: str) -> None:
"""Raise unless the active specification declares the int64 extension."""
if not get_context_spec().support_extension("int64"):
Comment thread
abm-77 marked this conversation as resolved.
raise TosaValueError(
f"TOSA spec {get_context_spec()} doesn't support int64 for {op}",
op=op,
)


def broadcast_shape(
input1: torch.Tensor, input2: torch.Tensor, op: str
) -> tuple[int | torch.SymInt, ...]:
Expand Down
Loading
Loading