Skip to content

Fix -Wunreachable-code-break findings in fbcode/executorch, xplat/executorch #24155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meta-codesync merged 1 commit into from
Oct 27, 2026
+6 −12
Merged

Fix -Wunreachable-code-break findings in fbcode/executorch, xplat/executorch #24155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion backends/vulkan/runtime/vk_api/Pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ VkImageLayout vk_layout(
default:
return VK_IMAGE_LAYOUT_GENERAL;
}
break;
case PipelineStage::TRANSFER:
switch (access) {
case MemoryAccessType::READ:
Expand Down
1 change: 0 additions & 1 deletion backends/vulkan/test/utils/test_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ void record_index_fill_buffer(api::Context* context, api::vTensor& v_ten) {
break;
default:
throw std::runtime_error("Unsupported dtype");
break;
}

api::ParamsBuffer params(api::context(), int32_t(v_ten.numel()));
Expand Down
1 change: 0 additions & 1 deletion backends/vulkan/test/vulkan_compute_api_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,6 @@ std::vector<int64_t> get_reference_strides(
default:
return {};
}
break;
case utils::kHeightPacked:
switch (sizes.size()) {
case 1:
Expand Down
3 changes: 0 additions & 3 deletions devtools/bundled_program/bundled_program.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,7 +338,6 @@ ET_NODISCARD Error load_bundled_input(
NotSupported,
"Data type %hhu not supported",
static_cast<uint8_t>(bundled_input->val_type()));
break;
}
}

Expand Down Expand Up @@ -450,7 +449,6 @@ ET_NODISCARD ErrorStats compute_method_output_error_stats(
"Data type %hhd not supported",
static_cast<uint8_t>(bundled_expected_output->val_type()));
return {Error::NotSupported, 0, 0, 0, 0};
break; // Never reached
}
}
}
Expand Down Expand Up @@ -532,7 +530,6 @@ ET_NODISCARD Error verify_method_outputs(
NotSupported,
"Data type %hhd not supported",
static_cast<uint8_t>(bundled_expected_output->val_type()));
break;
}
}
}
Expand Down
12 changes: 6 additions & 6 deletions runtime/executor/method_meta.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,22 +96,22 @@ Result<Tag> get_tag(
switch (serialization_value->val_type()) {
case executorch_flatbuffer::KernelTypes::Null: {
return Tag::None;
} break;
}
case executorch_flatbuffer::KernelTypes::Int: {
return Tag::Int;
} break;
}
case executorch_flatbuffer::KernelTypes::Double: {
return Tag::Double;
} break;
}
case executorch_flatbuffer::KernelTypes::Bool: {
return Tag::Bool;
} break;
}
case executorch_flatbuffer::KernelTypes::String: {
return Tag::String;
} break;
}
case executorch_flatbuffer::KernelTypes::Tensor: {
return Tag::Tensor;
} break;
}
default:
ET_LOG(
Error,
Expand Down
Loading