Skip to content

Only run unittest-editable on PRs that touch Python packaging #24674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobSzwejbka merged 1 commit into from
Nov 6, 2026
Merged

Only run unittest-editable on PRs that touch Python packaging #24674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/pull.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,7 +885,27 @@ jobs:
build-tool: cmake
docker-image: ci-image:executorch-ubuntu-22.04-clang12

# The editable install exercises the same unit tests as `unittest`; what it
# adds is coverage of the editable install path. Run it on PRs that touch
# Python packaging or the unittest/setup scripts, and on every push to main.
unittest-editable:
needs: changed-files
if: |
github.event_name != 'pull_request' ||
contains(needs.changed-files.outputs.changed-files, '.github/workflows/pull.yml') ||
contains(needs.changed-files.outputs.changed-files, '.github/workflows/_unittest.yml') ||
contains(needs.changed-files.outputs.changed-files, 'setup.py') ||
contains(needs.changed-files.outputs.changed-files, 'pyproject.toml') ||
contains(needs.changed-files.outputs.changed-files, 'install_executorch') ||
contains(needs.changed-files.outputs.changed-files, 'install_requirements') ||
contains(needs.changed-files.outputs.changed-files, 'install_utils.py') ||
contains(needs.changed-files.outputs.changed-files, 'requirements-') ||
contains(needs.changed-files.outputs.changed-files, 'src/executorch') ||
contains(needs.changed-files.outputs.changed-files, '.ci/scripts/unittest-') ||
contains(needs.changed-files.outputs.changed-files, '.ci/scripts/setup-linux.sh') ||
contains(needs.changed-files.outputs.changed-files, '.ci/scripts/setup-macos.sh') ||
contains(needs.changed-files.outputs.changed-files, '.ci/scripts/setup-windows.ps1') ||
contains(needs.changed-files.outputs.changed-files, '.ci/scripts/utils.sh')
uses: ./.github/workflows/_unittest.yml
permissions:
id-token: write
Expand Down
Loading