Repository navigation
Translate tools-share, tools-download, and skip-to-content in Greek - #15252
Merged
Merged
Conversation
Add the missing Greek strings for the book tools menu and the HTML skip link so those labels no longer fall back to English. See quarto-dev#14822 Co-authored-by: sogav21 <sogav21@users.noreply.github.com>
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
cderv
approved these changes
Nov 2, 2026
cderv
left a comment
cderv
left a comment
Member
There was a problem hiding this comment.
Thanks for the PR, the three translations look good to me.
One key is still missing from _language-el.yml compared to the English file, link-external-newwindow-label. It is read by screen readers after a link that opens in a new tab and is never shown as visible text. The English value is:
link-external-newwindow-label: "(opens in a new tab)"
Would you be able to add it to this PR? If not, no problem, we can take it in a separate one.
Co-authored-by: sogav21 <sogav21@users.noreply.github.com>
Contributor
Author
|
Done, added link-external-newwindow-label. Thanks for the review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the missing Greek values for the book tools menu and the HTML skip link, in the same positions as in
_language.yml:tools-share: "Κοινοποίηση" (Share)tools-download: "Λήψη" (Download)skip-to-content: "Μετάβαση στο κύριο περιεχόμενο" (Skip to main content)Greek books and HTML pages no longer fall back to English for these three strings. Follow-up to #15199, as suggested in its review.
See #14822
Prepared with AI assistance (Cursor) and reviewed by me.