Repository navigation
Conversation
The MIT license and GPL-2.0-or-later licenses are unused, in the case of the later the code is GPL-2 only which already has the license file present. Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
Collaborator
|
I believe the MIT license is used by nlohman_json library, and the gpl license is used by the uapi headers used in this library. |
Author
Is it actually included or just links against?
I believe that's covered by the included GPL-2.0-only.txt making the GPL-2.0-or-later.txt superfluous |
Collaborator
It's part of this build since it's a header only library, so IMO it should be included. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MIT license and GPL-2.0-or-later licenses are unused, in the case of the later the code is GPL-2 only which already has the license file present.